-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2451 schema build update defaults #2479
2451 schema build update defaults #2479
Conversation
…ero false-y defaults are no longer written
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #2479 +/- ##
==========================================
- Coverage 74.98% 74.93% -0.06%
==========================================
Files 85 85
Lines 9327 9356 +29
==========================================
+ Hits 6994 7011 +17
- Misses 2333 2345 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you!!
But the new mypy linting is failing, so we should have a look before merging :)
These are all not yet typed files, so it is a case related to this #2480 and can be ignored, I think |
I see! OK for me to merge then |
@nf-core-bot fix linting please! |
Fixes #2451
Implemented the option (via questionary) to update the schema defaults where the default in the pipeline appears to have changed.
A similar but reverse issue is found in #1954
Perhaps there is some scope here to issue warnings to assist in that?
Also implemented some additional code to ensure that non-zero False-y defaults are no longer written by python (current behaviour relies on web-builder to handle this but that is not used by all)
Considerations:
.nf-core.yml
) so that known divergent defaults can be safely ignored?PR checklist
CHANGELOG.md
is updateddocs
is updated