Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting and formatting of exponent values do not agree with each other in pipeline nextflow schema vs json #2710

Closed
jfy133 opened this issue Jan 31, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jfy133
Copy link
Member

jfy133 commented Jan 31, 2024

Description of the bug

We are trying to template merge 2.12 into nf-core/funcscan: https://github.com/nf-core/funcscan/actions/runs/7723141506/job/21052623682?pr=332

And we encounter a bunch of mismatches between exponent values between JSON schema and the nextflow config.

It appears that regardless of what you put in the 'nextflow_schema.json' schema, exponents are always formatted to 1e-09, whereas the nextflow config will always be 1E-9.

The only way we could get the linting to stop failing is to quote both, which is not ideal.

Command used and terminal output

No response

System information

No response

@jfy133 jfy133 added the bug Something isn't working label Jan 31, 2024
@jfy133
Copy link
Member Author

jfy133 commented Jan 31, 2024

It also appears that both linting forces large decimal 'numbers' to the different types of exponent

e.g. setting in funcscan in the nextflow.config

bgc_gecco_pfilter                       = 0.000000001

and in the nextflow_Schema.json

                "bgc_gecco_pfilter": {
                    "type": "number",
                    "description": "The p-value cutoff for protein domains to be included.",
                    "fa_icon": "fas fa-filter",
                    "default": 0.000000001,
                    "help_text": "The p-value cutoff for protein domains to be included.\n\nFor more information see the GECCO [documentation](https://github.com/zellerlab/GECCO).\n\n> Modifies tool parameter(s):\n> - GECCO: `--pfilter`"
                },

I still get the following linting error:

│ nextflow_config: Config default value incorrect: params.bgc_gecco_pfilter is set as 1e-09 in nextflow_schema.json but is 1E-9 in nextflow.config.          │

@mashehu
Copy link
Contributor

mashehu commented Feb 9, 2024

fixed in #2712

@mashehu mashehu closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants