Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use types for default value comparison #2712

Merged
merged 6 commits into from
Feb 1, 2024
Merged

use types for default value comparison #2712

merged 6 commits into from
Feb 1, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Jan 31, 2024

No description provided.

@mashehu mashehu requested a review from mirpedrol January 31, 2024 16:18
mirpedrol
mirpedrol approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

tests/lint/nextflow_config.py Outdated Show resolved Hide resolved
@mashehu @mirpedrol
Update tests/lint/nextflow_config.py
0fe6533 
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
@mashehu mashehu mentioned this pull request Feb 1, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ca054a8) 73.49% compared to head (ef65f76) 73.59%.
Report is 6 commits behind head on dev.

Files Patch % Lines
nf_core/schema.py 78.57% 6 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mashehu mashehu merged commit d7e81bd into nf-core:dev Feb 1, 2024
36 checks passed
@mashehu mashehu deleted the type-schema branch February 1, 2024 09:44
@mashehu mashehu mentioned this pull request Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mashehu @mirpedrol @nf-core-bot