Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle float values correctly in default value comparison #2711

Closed
wants to merge 6 commits into from
Closed

handle float values correctly in default value comparison #2711

wants to merge 6 commits into from

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Jan 31, 2024

fixes #2710

@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca054a8) 73.49% compared to head (9cb662c) 73.43%.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mirpedrol
mirpedrol approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

tests/lint/nextflow_config.py Outdated Show resolved Hide resolved
@mashehu @mirpedrol
Update nextflow_config.py
9cb662c 
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
@mashehu
Copy link
Contributor Author

mashehu commented Feb 1, 2024

superseded by #2712

@mashehu mashehu closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mashehu @mirpedrol @nf-core-bot