-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial working version of refgenie integration #1090
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1090 +/- ##
==========================================
+ Coverage 64.68% 64.91% +0.22%
==========================================
Files 55 56 +1
Lines 6338 6428 +90
==========================================
+ Hits 4100 4173 +73
- Misses 2238 2255 +17
Continue to review full report at Codecov.
|
Hey, this is great! One suggestion is to add a note into the NF_CFG_TEMPLATE = """
# This is a read-only config file managed by refgenie. Manual changes to this file will be overwritten
# To make changes here, use refgenie to update the reference genome data
params {{
genomes {{
{content}
}}
}}
""" |
Good idea thanks! |
TODO:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with:
- Initialize refgenie:
refgenie init -c refgenie-config.yml
refgenie_genomes.config is created at~/.nextflow/nf-core/refgenie_genomes.config
an includeConfig statement is added at~/.nextflow/config
- Download a new asset:
refgenie pull t7/fasta -c refgenie-config.yml
refgenie_genomes.config file is updated with the genome path
I think this should be cf. https://www.nextflow.io/docs/latest/config.html#configuration-file
|
It is! It was a typo in my comment. I edit the comment to avoid confusion, thanks for spotting it! |
Yes I was looking for the error in the code and couldn't see it, so was beginning to wonder! 😅 |
Follow-on PR needed to document usage here: https://nf-co.re/docs/usage/reference_genomes |
Can't believe it's finally merged! 👏🏻 🚀 🤩 Awesome work @KevinMenden @mirpedrol 😀 |
Adding support for automatic updating of nextflow config files with a refgenie database.
If a refgenie database is used and updated, the
update_config()
function is triggered, which:refgenie_genomes.config
file in the refgenie config file or inNXF_REFGENIE
environment variable$NXF_HOME/nf-core/refgenie_genomes.config
refgenie_genomes.config
with the latest refgenie databaseincludeConfig
statement to the$NXF_HOME/config
file if not already existingThis is still very much a WIP, especially with respect to robustness/bugs.
PR checklist
CHANGELOG.md
is updateddocs
is updated