Updated gh actions for release #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewels
reviewed
Jun 25, 2021
|
|
||
| dir: | ||
| - latest | ||
| - ${{ github.ref }} |
There was a problem hiding this comment.
This is meant to be just the release name, right? I think that the ref gives something like refs/tags/0.3.1 or similar.
In the past I've used ${{ github.event.release.tag_name }} for this. eg.
There was a problem hiding this comment.
This is true, I thought we would only get 0.3.1 but I misread the docs. Either way, github.event.release.tag_name shows more clearly what we are trying to achieve.
Co-authored-by: Phil Ewels <phil.ewels@scilifelab.se>
ewels
approved these changes
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully solve #1073.
PR checklist
CHANGELOG.mdis updateddocsis updated