Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated gh actions for release #1128

Merged
merged 3 commits into from
Jun 26, 2021
+3 −2
Merged

Updated gh actions for release #1128

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c26baee
Change GITHUB_REF to github.ref
ErikDanielsson Jun 24, 2021
449bb7d
Fix failing lint test
ErikDanielsson Jun 24, 2021
5596da9
Apply changes from code review
ErikDanielsson Jun 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/tools-api-docs-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ jobs:
runs-on: ubuntu-18.04
strategy:
matrix:
dir: [latest, $GITHUB_REF]

dir:
- latest
- ${{ github.ref }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to be just the release name, right? I think that the ref gives something like refs/tags/0.3.1 or similar.

In the past I've used ${{ github.event.release.tag_name }} for this. eg.

tools/.github/workflows/push_dockerhub_release.yml

Line 32 in 7721f37

docker push nfcore/${{ matrix.image }}:${{ github.event.release.tag_name }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true, I thought we would only get 0.3.1 but I misread the docs. Either way, github.event.release.tag_name shows more clearly what we are trying to achieve.

ErikDanielsson marked this conversation as resolved.
Show resolved Hide resolved
steps:
- name: Check out source-code repository
uses: actions/checkout@v2
Expand Down