Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module lint: Fail instead of warn if local copy edited #1357

Merged
merged 5 commits into from
Dec 14, 2021

Conversation

ewels
Copy link
Member

@ewels ewels commented Dec 9, 2021

If the local copy of a module is edited and does not match the remote, throw an error instead of a warning (with a clearer message too).

Fixes #1313

Not sure if there are cases where we don't want this to happen? But I can't think of any.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels
Copy link
Member Author

ewels commented Dec 9, 2021

CI failing because we are now picking up the fact that the pytests edit files in place for the purposes of testing 🤦🏻‍♂️

@codecov

This comment has been minimized.

Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@ewels ewels merged commit d7954e4 into nf-core:dev Dec 14, 2021
@ewels ewels deleted the module-lint-fail-if-local-edited branch December 14, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants