Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn instead of fail if module is different from remote #1364

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

drpatelh
Copy link
Member

Reverts #1357 because modules will be changed on PRs to nf-core/modules and hence always result in linting failures.

Couldn't see a CHANGELOG entry so just the 1 word to change. Nothing else to see here.

Copy link

@GCJMackenzie GCJMackenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! Thanks for the quick fix :)

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #1364 (a5dc3c8) into dev (5f8fad6) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1364   +/-   ##
=======================================
  Coverage   67.01%   67.01%           
=======================================
  Files          50       50           
  Lines        5682     5682           
=======================================
  Hits         3808     3808           
  Misses       1874     1874           
Impacted Files Coverage Δ
nf_core/modules/lint/module_changes.py 80.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f8fad6...a5dc3c8. Read the comment docs.

@drpatelh drpatelh merged commit 694dd44 into nf-core:dev Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants