First attempt to make download work with new DSL2 syntax. #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully closes nf-core#1379. Needs testing.
|
Opening this a little early as I'm still technically ill and not working, but want to get this moving ASAP. Any help with testing much appreciated. Apologies in advance for dumb errors. I'm going to go and take a nap now. 🤒 😴 |
|
Ok I lied, I didn't go to bed yet and did some very quick testing to make sure that it runs (it didn't). Speed test looks good at my end now: ✅ Finds 28 containers for nf-core/rnaseq version 3.2 (old DSL2 syntax) More testing by others would be much appreciated 👍🏻 |
This comment has been minimized.
This comment has been minimized.
drpatelh
reviewed
Jan 20, 2022
| if matches: | ||
| for match in matches: | ||
| # Look for a http download URL. | ||
| # Thanks Stack Overflow for the regex: https://stackoverflow.com/a/3809435/713980 |
drpatelh
reviewed
Jan 20, 2022
| for match in matches: | ||
| # Look for a http download URL. | ||
| # Thanks Stack Overflow for the regex: https://stackoverflow.com/a/3809435/713980 | ||
| url_regex = r"https?:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_\+.~#?&//=]*)" |
drpatelh
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the code-scraping-code that discovers container URLs in DSL2 module code. Hopefully now works with both old and new DSL2 styles. Should close #1379.
PR checklist
CHANGELOG.mdis updateddocsis updated