-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support patch file in nf-core modules update
#1710
Support patch file in nf-core modules update
#1710
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1710 +/- ##
==========================================
+ Coverage 68.25% 68.59% +0.33%
==========================================
Files 57 58 +1
Lines 6744 6820 +76
==========================================
+ Hits 4603 4678 +75
- Misses 2141 2142 +1
Continue to review full report at Codecov.
|
nf-core modules update
1418ce3
to
46f60d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for the review! I need to handle the merge conflict before merging though, its a pretty tricky one |
Continuation from #1708 (merge that one first). This PR adds support for automatic application of patches created with
nf-core modules patch
. The command works by looking for the original lines of the current installation in the new version of the module. If they are found, it replaces them with the modified lines. If there is a conflict between the modifications by the patch file and the update, the new files are installed but the patch file is preserved so the user can apply it manually.The new feature is tested using a special branch in the
nf-core/modules-test
repository on GitLab containing only thebismark/align
module:patch-tester
. The branch contains three commits in total: One containing the original version of the module, one where a change has been made that shouldn't affect the patch file created by the tests and one that should. The commands are tested by creating the patch file on the original version of the module, and then trying to update to the different versions.PR checklist
CHANGELOG.md
is updateddocs
is updated