-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support patch file in nf-core modules lint
#1716
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1716 +/- ##
==========================================
- Coverage 68.99% 68.24% -0.75%
==========================================
Files 58 59 +1
Lines 6960 7080 +120
==========================================
+ Hits 4802 4832 +30
- Misses 2158 2248 +90
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks! :)
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
Thanks for the review! |
Continuation from #1708 and #1710. This PR adds support for patch files when linting modules. I have added a new module lint test
module_patch
that checks if a module's patch file is valid and reversible (i.e. we can construct the original files from it). In the other lint tests, the patch is reversed before performing any checking. However, I'm not sure if this is the optimal approach: would it be better in for example themain_nf
test to lint the modified file and only report warnings if the lint fails?I've waited with adding tests for patches in nf-core lint, since I want to do it in a similar fashion as in #1708 and #1710. This is not possible currently due to #1715.
PR checklist
CHANGELOG.md
is updateddocs
is updated