Modules restructure #1859
Modules restructure #1859
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1859 +/- ##
==========================================
- Coverage 64.64% 64.49% -0.16%
==========================================
Files 34 34
Lines 4115 4137 +22
==========================================
+ Hits 2660 2668 +8
- Misses 1455 1469 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -93,7 +93,8 @@ def init_mod_name(self, module): | |||
| if self.repo_type == "modules": | |||
| modules = self.get_modules_clone_modules() | |||
| else: | |||
| modules = self.modules_json.get_all_modules().get(self.modules_repo.fullname) | |||
| modules = self.modules_json.get_all_modules().get(self.modules_repo.remote_url) | |||
| modules = [module if dir == "nf-core" else f"{dir}/{module}" for dir, module in modules] | |||
There was a problem hiding this comment.
Reading quickly so can't see the full context, but why do we need special treatment for nf-core here?
There was a problem hiding this comment.
This is to get the module name suggestions, it will usually be nf-core, so we don't need to have nf-core/TOOL, but in case you have modules from other repos I thought it would be nice to differentiate and have the other directory listed.
| @@ -153,7 +156,7 @@ def get_local_yaml(self): | |||
|
|
|||
| log.debug(f"Module '{self.module}' meta.yml not found locally") | |||
| else: | |||
| module_base_path = os.path.join(self.dir, "modules") | |||
| module_base_path = os.path.join(self.dir, "modules", "nf-core") | |||
There was a problem hiding this comment.
As above, hardcoded nf-core strings make me nervous 😅
|
checks are all green, that's good enough for me |
Apply the changes needed for the restructure of the nf-core/modules repository.
PR checklist
CHANGELOG.mdis updateddocsis updated