Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip execution order of parameter summary and validation #2033

Merged
merged 4 commits into from
Nov 21, 2022

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Nov 21, 2022

This is to prevent 'hiding' or 'loss' of parameter errors (mainly non-failing typos in parameter names), that can come due to very long parameter summary + small terminal windows.

Originally proposed here: https://nfcore.slack.com/archives/CE4K7FEHE/p1669035465524059

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@jfy133 jfy133 changed the base branch from master to dev November 21, 2022 13:29
@github-actions
Copy link
Contributor

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @jfy133,

It looks like this pull-request is has been made against the jfy133/nf-core-tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the jfy133/nf-core-tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #2033 (6baf7f6) into dev (2243440) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2033   +/-   ##
=======================================
  Coverage   67.41%   67.41%           
=======================================
  Files          42       42           
  Lines        5463     5463           
=======================================
  Hits         3683     3683           
  Misses       1780     1780           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@apeltzer apeltzer merged commit c3265c3 into nf-core:dev Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants