Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip execution order of parameter summary and validation #2033

Merged
merged 4 commits into from
Nov 21, 2022
Merged

Flip execution order of parameter summary and validation #2033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42d528b
Flip order of parmater summary and validation to prevent hiding of pa…
jfy133 Nov 21, 2022
3cd6b74
Update CHANGELOG.md
jfy133 Nov 21, 2022
cf1a57c
Linting
jfy133 Nov 21, 2022
6baf7f6
Merge branch 'dev' into dev
jfy133 Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- Check that the workflow name provided with a template doesn't contain dashes ([#1822](https://github.com/nf-core/tools/pull/1822))
- `nextflow run <pipeline> --version` will now print the workflow version from the manifest and exit ([#1951](https://github.com/nf-core/tools/pull/1951))
- Add profile for running `docker` with the ARM chips (including Apple silicon) ([#1942](https://github.com/nf-core/tools/pull/1942) and [#2034](https://github.com/nf-core/tools/pull/2034))
- Flip execution order of parameter summary printing and parameter validation to prevent 'hiding' of parameter errors.

### Linting

Expand Down
7 changes: 3 additions & 4 deletions nf_core/pipeline-template/lib/WorkflowMain.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,14 @@ class WorkflowMain {
System.exit(0)
}

// Print parameter summary log to screen
log.info paramsSummaryLog(workflow, params, log)

// Validate workflow parameters via the JSON schema
if (params.validate_params) {
NfcoreSchema.validateParameters(workflow, params, log)
}

// Print parameter summary log to screen

log.info paramsSummaryLog(workflow, params, log)

// Check that a -profile or Nextflow config has been provided to run the pipeline
NfcoreTemplate.checkConfigProvided(workflow, log)

Expand Down