Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for docker pull commands in actions_ci lint test (leftover from DSL1) #2055

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Nov 25, 2022

Don't check for docker pull commands in actions_ci lint test (leftover from DSL1)

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@muffato muffato self-requested a review November 25, 2022 20:02
Also remove the pre-commit test about filenames, as it fails with majority of test files.
@ewels
Copy link
Member Author

ewels commented Nov 25, 2022

NB: The pre-commit hook name-tests-test test was failing because it wants all pytest files to be prefixed test_. Rather than renaming about 50 files in the repo, I just removed that test.

@muffato
Copy link
Member

muffato commented Nov 25, 2022

Thanks, I was about to push that commit too

@ewels
Copy link
Member Author

ewels commented Nov 25, 2022

Sorry I didn't do it earlier, opened the PR just before doing a talk so only saw the failing tests just now.

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #2055 (d004a24) into dev (bbb5415) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2055      +/-   ##
==========================================
+ Coverage   67.60%   67.61%   +0.01%     
==========================================
  Files          43       43              
  Lines        5572     5580       +8     
==========================================
+ Hits         3767     3773       +6     
- Misses       1805     1807       +2     
Impacted Files Coverage Δ
nf_core/modules/lint/__init__.py 82.88% <0.00%> (-0.54%) ⬇️
nf_core/components/remove.py 86.30% <0.00%> (-0.47%) ⬇️
nf_core/__main__.py 58.45% <0.00%> (ø)
nf_core/components/install.py 88.81% <0.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ewels ewels merged commit 0ba69a4 into nf-core:dev Nov 25, 2022
@ewels ewels deleted the actions-ci-remove-dsl1-docker branch November 25, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants