Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev -> Master for v2.7 #2107

Merged
merged 918 commits into from
Dec 8, 2022
Merged

Dev -> Master for v2.7 #2107

merged 918 commits into from
Dec 8, 2022

Conversation

mirpedrol
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

mashehu and others added 30 commits November 25, 2022 11:37
Add subworkflows test command to __main__.py
Check structure of update entry in .nf-core.yml
Return remote params to remove commands
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Don't lint pipeline name if `manifest.name` in `.nf-core.yml`
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #2107 (3121dab) into master (dec66ab) will increase coverage by 3.52%.
The diff coverage is 67.22%.

@@            Coverage Diff             @@
##           master    #2107      +/-   ##
==========================================
+ Coverage   64.44%   67.97%   +3.52%     
==========================================
  Files          35       43       +8     
  Lines        4180     5633    +1453     
==========================================
+ Hits         2694     3829    +1135     
- Misses       1486     1804     +318     
Impacted Files Coverage Δ
nf_core/bump_version.py 89.47% <ø> (-0.19%) ⬇️
nf_core/lint/modules_structure.py 88.88% <ø> (ø)
nf_core/lint/multiqc_config.py 66.66% <ø> (ø)
nf_core/lint/pipeline_name_conventions.py 81.81% <ø> (ø)
nf_core/lint/pipeline_todos.py 94.11% <ø> (ø)
nf_core/lint/readme.py 75.75% <ø> (ø)
nf_core/lint/schema_description.py 67.85% <ø> (ø)
nf_core/lint/schema_lint.py 75.86% <ø> (ø)
nf_core/lint/schema_params.py 76.00% <ø> (ø)
nf_core/lint/template_strings.py 87.50% <ø> (ø)
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@awgymer
Copy link
Contributor

awgymer commented Dec 7, 2022

Should we add/expand docs on how to structure your own private modules repo and some of the possible gotchas?

I am thinking particularly regarding org_path in the .nf-core.yml and the risks of having two modules with the same name.

If these are already done and I missed it ignore me. Otherwise I could work on some tomorrow?

@mashehu
Copy link
Contributor

mashehu commented Dec 7, 2022

Should we add/expand docs on how to structure your own private modules repo and some of the possible gotchas?

I am thinking particularly regarding org_path in the .nf-core.yml and the risks of having two modules with the same name.

If these are already done and I missed it ignore me. Otherwise I could work on some tomorrow?

Good idea, but I think these would be over at the nf-co.re repo and not needed here, right?

@awgymer
Copy link
Contributor

awgymer commented Dec 7, 2022

Hmm maybe. I only reviewed the readme on the main page and there are some comments about private repos and needing a "structure" but nothing specific. I would probably at least link to wherever we will put them on nf-co.re

@mirpedrol
Copy link
Member Author

We have some documentation on the readme. We could add a sentence about org_path. I opened a PR, please make all the changes that you consider 🙂 Then we can release 🚀

mirpedrol and others added 4 commits December 8, 2022 10:09
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: awgymer <24782660+awgymer@users.noreply.github.com>
@mirpedrol mirpedrol merged commit 58da1e3 into master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants