-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --empty-template flag for creating modules #2175
Conversation
Dev -> Master for v2.7.2
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report
@@ Coverage Diff @@
## dev #2175 +/- ##
==========================================
- Coverage 71.54% 71.53% -0.01%
==========================================
Files 77 77
Lines 8367 8340 -27
==========================================
- Hits 5986 5966 -20
+ Misses 2381 2374 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Nice! I am just not 100% sure about the parameter name (as usual 🙄). "minimal" is a bit too vague for me (could for example mean without tests, like we do for local modules). What do you think about |
🤔 There are also some things stripped apart from TODOs, like the command example. Maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinking more about this functionality, it might be cumbersome to always have to remove the todo statements, at the same time they help to be sure one doesn't forget something (which might happen easily with all the different files). Do we lint for the most important things we mention in the todos?
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Yes, I agree it's good to have them as a checklist, I think this feature is only for people who are very used to add modules and don't need them. |
Close #2091
How to run
nf-core modules create --empty-template foo
Output files:
modules/nf-core/foo/main.nf
modules/nf-core/foo/meta.yml
tests/modules/nf-core/foo/main.nf
tests/modules/nf-core/foo/test.yml
PR checklist
CHANGELOG.md
is updateddocs
is updated