-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allowing new line before description field #2177
Conversation
I think it is fine to just merge this (and add the PR number as a second reference in the changelog entry) |
nf-core/modules#2847 broke some tests 💀 |
why would the rename break the tests? Is something not updated? |
We install the subworkflow to an old version, as the module in this subworkflow has the old name when it tries to install it from nf-core/modules it's not found. |
:shacking-fist: @maxulysse |
It might actually be a bug on tools 🤔 |
I actually corrected the subworkflow name |
How come? all my tests where ✔️ |
I think the problem is that we check if the module is available before installing it, and to do this we get the list of available modules from the last |
Codecov Report
@@ Coverage Diff @@
## dev #2177 +/- ##
==========================================
+ Coverage 71.51% 71.55% +0.04%
==========================================
Files 77 77
Lines 8338 8347 +9
==========================================
+ Hits 5963 5973 +10
+ Misses 2375 2374 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Fix a typo that I introduced with #2175
The
description
field ofmeta.yml
when the flag was not provided was attached to the previous line (without a new line).We can sneak this into the next PR as it's a tiny change, leaving it here as a reminder.
PR checklist
CHANGELOG.md
is updateddocs
is updated