Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add version and subpath to multiqc report comment link #2298

Merged
merged 6 commits into from
Jun 1, 2023
Merged

add version and subpath to multiqc report comment link #2298

merged 6 commits into from
Jun 1, 2023

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Jun 1, 2023 •
edited
Loading

fixes #2297

FriederikeHanssen
FriederikeHanssen approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very speedy, thank you 🙏

@codecov
Copy link

codecov bot commented Jun 1, 2023 •
edited
Loading

Codecov Report

Merging #2298 (531f977) into dev (ef62904) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #2298      +/-   ##
==========================================
- Coverage   72.93%   72.86%   -0.07%     
==========================================
  Files          77       77              
  Lines        8446     8440       -6     
==========================================
- Hits         6160     6150      -10     
- Misses       2286     2290       +4
Impacted Files Coverage Δ
nf_core/bump_version.py 91.37% <100.00%> (+0.15%) ⬆️
nf_core/lint/multiqc_config.py 67.24% <100.00%> (+0.57%) ⬆️

... and 9 files with indirect coverage changes

@mashehu mashehu merged commit 4b1a3b8 into nf-core:dev Jun 1, 2023
@mirpedrol mirpedrol mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mashehu @mirpedrol @FriederikeHanssen