Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apptainer (Singularity) to Gitpod nf-core base image #2345

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

MatthiasZepper
Copy link
Member

To test and develop the respective features for #2336, I had to install Apptainer in Gitpod several times a day.

Although I am not sure how often other people will need it, I see little harm in adding Apptainer by default to the Gitpod image. The image is already quite bloated with conda, so the additional 80MB-100MB will barely matter?

Unfortunately, I could not test the new image. I tried to build it locally, but the RUN nextflow self-update step seems to get stuck at Downloading dependency org.pf4j:pf4j-update:jar:2.3.0. That one step is running now since 5h and the whole build so far is taking a little over 7h, which I think might be a MacM1 issue?

So whoever will review this PR should please clone this, navigate to the folder cd tools and run

docker build . -f nf_core/gitpod/gitpod.Dockerfile -t testgitpodwithapptainer

to see if the image builds successfully and how big the new image will be.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #2345 (ae53738) into dev (b5eb200) will decrease coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2345      +/-   ##
==========================================
- Coverage   73.08%   72.69%   -0.39%     
==========================================
  Files          78       78              
  Lines        8784     8864      +80     
==========================================
+ Hits         6420     6444      +24     
- Misses       2364     2420      +56     

see 2 files with indirect coverage changes

@ewels ewels merged commit df428cb into nf-core:dev Jun 29, 2023
@MatthiasZepper
Copy link
Member Author

Thx.

PS: I like indentation too, but one of the code formatters that are run on save in my editor (prettier? black?) didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants