Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Change URL to release tag #2412

Merged
merged 4 commits into from
Sep 19, 2023
Merged

FIX: Change URL to release tag #2412

merged 4 commits into from
Sep 19, 2023

Conversation

maxulysse
Copy link
Member

Change URL to the release tag

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Change URL to the release tag
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to make the same change in the linting test multiqc_config.py https://github.com/nf-core/tools/blob/master/nf_core/lint/multiqc_config.py#L78

@mirpedrol mirpedrol added this to the 2.10 milestone Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #2412 (6b20a81) into dev (ba395fe) will decrease coverage by 0.17%.
Report is 16 commits behind head on dev.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2412      +/-   ##
==========================================
- Coverage   71.23%   71.07%   -0.17%     
==========================================
  Files          87       87              
  Lines        9415     9431      +16     
==========================================
- Hits         6707     6703       -4     
- Misses       2708     2728      +20     
Files Changed Coverage Δ
nf_core/lint/multiqc_config.py 67.79% <ø> (ø)

... and 2 files with indirect coverage changes

@mirpedrol mirpedrol merged commit c84cc4a into dev Sep 19, 2023
20 checks passed
@mirpedrol mirpedrol deleted the maxulysse-patch-1 branch September 19, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants