Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix subworkflow template jinja variable for subworkflow name #2435

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

mirpedrol
Copy link
Member

Close #2432

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #2435 (b156469) into dev (6b20a81) will increase coverage by 0.07%.
Report is 27 commits behind head on dev.
The diff coverage is 20.83%.

@@            Coverage Diff             @@
##              dev    #2435      +/-   ##
==========================================
+ Coverage   71.07%   71.14%   +0.07%     
==========================================
  Files          87       87              
  Lines        9431     9431              
==========================================
+ Hits         6703     6710       +7     
+ Misses       2728     2721       -7     
Files Changed Coverage Δ
nf_core/download.py 59.35% <20.83%> (ø)

... and 1 file with indirect coverage changes

@mirpedrol mirpedrol requested a review from mashehu September 25, 2023 07:27
@mirpedrol mirpedrol merged commit 54d06e8 into nf-core:dev Sep 25, 2023
20 checks passed
@mirpedrol mirpedrol deleted the fix-subworkflows-create-name branch September 25, 2023 08:01
@mirpedrol mirpedrol restored the fix-subworkflows-create-name branch November 3, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants