Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev -> Master for 2.12.1 #2718

Merged
merged 63 commits into from
Feb 1, 2024
Merged

Dev -> Master for 2.12.1 #2718

merged 63 commits into from
Feb 1, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Feb 1, 2024

No description provided.

renovate bot and others added 30 commits January 29, 2024 14:39
@renovate
Pin dependencies
f287057
@mirpedrol
bump to 2.13dev
e9e755c
@mirpedrol
Update CHANGELOG.md
917890b
@mirpedrol
Merge pull request #2702 from mirpedrol/bump-2.13dev
0ec52ee 
bump to 2.13dev [skip changelog]
@mashehu
Merge branch 'dev' into renovate/pin-dependencies
ba7b83c
@mirpedrol
handle default read as float when type is number
23f0dae
@renovate
Update pre-commit hook astral-sh/ruff-pre-commit to v0.1.15
32863da
@nf-core-bot
[automated] Update CHANGELOG.md
0f00b4c
@mashehu
Merge pull request #2705 from nf-core/renovate/astral-sh-ruff-pre-com…
beec488 
…mit-0.x
@mirpedrol
Merge branch 'dev' into linting-defaults
125d356
@nf-core-bot
[automated] Update CHANGELOG.md
57e69a5
@mirpedrol
Merge pull request #2703 from mirpedrol/linting-defaults
ef4d323 
Linting: Handle default values of type number from nextflow schema
@mashehu
Merge branch 'dev' into renovate/pin-dependencies
ffdc82d
@mashehu
Merge pull request #2701 from nf-core/renovate/pin-dependencies
41d9839 
Pin dependencies
@mirpedrol
fix ignoring files_unchanged
b3fdaf1
@nf-core-bot
[automated] Update CHANGELOG.md
c4be616
@mirpedrol
fix changelog titles
a28f0d3
@nf-core-bot
[automated] Update CHANGELOG.md
4b62733
@mashehu
fix types in files_unchanged
06a4c32
@mashehu
fix typing in files_exist
e0cf4eb
@mirpedrol
Merge pull request #2 from mashehu/files-unchanged
7a757e4 
add more typing
@mashehu
avoid circular import
f7827f6
@mashehu
fix linting
8410892
@mashehu
fix plugin entry
d41694b
@mashehu
fix plugin entry
20c8203
@mirpedrol
Update nf_core/lint/files_exist.py
81a3f7a
@mirpedrol
Merge pull request #2708 from mirpedrol/changelog-titles
58c7088 
fix changelog titles
@mashehu
Merge branch 'files-unchanged' of github.com:mirpedrol/tools into fil…
09f2afa 
…es-unchanged
@mashehu
fix paths, ignored listing and remove debugging
4f6522a
@mashehu
print relative path not absolute path in logo cmd
2a01fa7
mashehu and others added 20 commits January 31, 2024 12:33
@mashehu
add tests for conditionals
59cbb3f
@mashehu @mirpedrol
Update tests/test_lint.py
c445b93 
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
@mashehu
Merge pull request #2709 from mashehu/output-path-for-logo
c149db5 
Print relative path not absolute path in logo cmd log output
@mashehu
fix linting
09a3514
@mashehu
Merge pull request #2707 from mirpedrol/files-unchanged
ca054a8 
Linting: fix ignoring files_unchanged
@mashehu
handle float values in default value comparison
445eccf 
fixes 2710
@mashehu
use type based file default value comparison
04bc025
@nf-core-bot
[automated] Update CHANGELOG.md
4e9cb73
@mashehu
Merge branch 'dev' into type-schema
1ada287
@renovate
Update codecov/codecov-action action to v4
cdedbc5
@nf-core-bot
[automated] Update CHANGELOG.md
dc92977
@mashehu
Merge pull request #2713 from nf-core/renovate/codecov-codecov-action…
5ff453e 
…-4.x

Update codecov/codecov-action action to v4
@mashehu
let renovate ignore nf-core-bot
4840879
@nf-core-bot
[automated] Update CHANGELOG.md
424d21b
@mashehu
Merge pull request #2716 from mashehu/ignore-nf-core-bot-in-renovate
571413e 
Ignore nf-core-bot in renovate PRs
@mashehu @mirpedrol
Update tests/lint/nextflow_config.py
0fe6533 
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
@mashehu
fix schema tests
ef65f76
@mashehu
Merge pull request #2712 from mashehu/type-schema
d7e81bd 
use types for default value comparison
@mashehu
bump to 2.12.1
0bf3b0e
@mashehu
Merge pull request #2717 from mashehu/bump-version
20ab24b 
Bump version to 2.12.1
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3588841) 73.46% compared to head (1114256) 73.65%.
Report is 2 commits behind head on master.

❗ Current head 1114256 differs from pull request most recent head 693e967. Consider uploading reports for the commit 693e967 to get more accurate results

Files Patch % Lines
nf_core/schema.py 78.57% 6 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mashehu mashehu merged commit 776089a into master Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mashehu @mirpedrol @nf-core-bot