Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak TODO string in test_yml_builder.py #966

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 24, 2021

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #966 (67a5994) into dev (398479c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 67a5994 differs from pull request most recent head f666c05. Consider uploading reports for the commit f666c05 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #966      +/-   ##
==========================================
- Coverage   69.31%   69.30%   -0.02%     
==========================================
  Files          34       34              
  Lines        4224     4225       +1     
==========================================
  Hits         2928     2928              
- Misses       1296     1297       +1     
Impacted Files Coverage Δ
nf_core/modules/create.py 59.57% <0.00%> (-0.32%) ⬇️
nf_core/modules/test_yml_builder.py 16.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 398479c...f666c05. Read the comment docs.

@github-actions
Copy link
Contributor

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@nf-core nf-core deleted a comment from github-actions bot Mar 24, 2021
@ewels ewels enabled auto-merge March 24, 2021 19:02
@ewels ewels merged commit 8e188e7 into dev Mar 24, 2021
@ewels ewels deleted the test_yml_builder_todo_tweak branch March 26, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants