Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak TODO string in test_yml_builder.py #966

Merged
merged 3 commits into from
Mar 24, 2021
Merged

tweak TODO string in test_yml_builder.py #966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d2f521
tweak TODO string in test_yml_builder.py
ewels Mar 24, 2021
67a5994
tweak log output in bioconda package name prompt
ewels Mar 24, 2021
f666c05
Black
ewels Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions nf_core/modules/create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,9 @@ def create(self):
log.info(f"Using Bioconda package: '{self.bioconda}'")
break
except (ValueError, LookupError) as e:
if rich.prompt.Confirm.ask(
f"[violet]Could not find Conda dependency using the Anaconda API: '{self.tool}'. Do you want to enter a different bioconda package name?"
):
self.tool_conda_name = rich.prompt.Prompt.ask("[violet]Name of tool/subtool").strip()
log.warning(f"Could not find Conda dependency using the Anaconda API: '{self.tool}'")
if rich.prompt.Confirm.ask(f"[violet]Do you want to enter a different Bioconda package name?"):
self.tool_conda_name = rich.prompt.Prompt.ask("[violet]Name of Bioconda package").strip()
continue
else:
log.warning(
Expand Down
2 changes: 1 addition & 1 deletion nf_core/modules/test_yml_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def get_md5_sums(self, entry_point, command):
test_files[i].pop("md5sum")
test_files[i][
"contains"
] = "# TODO nf-core: md5sum test not possible, please replace this comment with a string in the file"
] = "# TODO nf-core: file md5sum was variable, please replace this text with a string found in the file instead"

if len(test_files) == 0:
raise UserWarning(f"Could not find any test result files in '{results_dir}'")
Expand Down