Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda name flag #989

Merged
merged 5 commits into from
Apr 7, 2021
Merged

Conda name flag #989

merged 5 commits into from
Apr 7, 2021

Conversation

KevinMenden
Copy link
Contributor

@KevinMenden KevinMenden commented Apr 6, 2021

This PR adds a --conda-name, -c flag to nf-core modules create to allow sidestepping of questionary, e.g. during pytest.

Fixes #988

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #989 (c2ff72e) into dev (21e6b3a) will increase coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #989   +/-   ##
=======================================
  Coverage   69.21%   69.22%           
=======================================
  Files          34       34           
  Lines        4256     4257    +1     
=======================================
+ Hits         2946     2947    +1     
  Misses       1310     1310           
Impacted Files Coverage Δ
nf_core/__main__.py 61.39% <66.66%> (+0.12%) ⬆️
nf_core/modules/create.py 59.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21e6b3a...c2ff72e. Read the comment docs.

nf_core/__main__.py Outdated Show resolved Hide resolved
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @KevinMenden Just a minor comment.

nf_core/__main__.py Outdated Show resolved Hide resolved
tests/test_modules.py Outdated Show resolved Hide resolved
KevinMenden and others added 3 commits April 7, 2021 07:25
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
@KevinMenden KevinMenden merged commit 629d98f into nf-core:dev Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants