-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add branch+commit to the "What to Test" field in TestFlight #23
Comments
@sethgagnon , to get #63 merged, we should also add documentation about the workaround mentioned above. Would you like to add this to the docs? |
This was originally introduced by @MikePlante1 in iAPS Artificial-Pancreas/iAPS#360 This PR includes a feature for uploading the branch name and git reference as a “changelog” to TestFlight, displayed under “What to Test” for each build. However , there is a bug in AppStore Connect / TestFlight, where fastlane fails to upload changelog if it was never entered before. The workaround is to make a manual “Test Details” entry from AppStoreConnect (ASC), then build again. Then, the branch and git ref will be displayed under "What to Test" in both TestFlight and ASC. See nightscout/Trio#23 and nightscout/Trio#63 for details
I think this should be closed but deferring to @bjornoleh
|
@marionbarker , there is a documented way to activate the change log in TestFlight, but unfortunately it’s an unnecessarily cumbersome one. The intention was that this should go into the docs instead.: Could l someone replace the existing one with this? And perhaps make a note that it’s optional/ non-critical for the setup of the TestFlight app Maybe @sethgagnon could do this? Thanks 😊 |
Closing this issue as completed now that @marionbarker added the easy instructions to the docs. Thanks! |
oref0 branch: dev - git version: e023125 Last commits: e023125 Replace Open-iAPS with Trio (#23)
Use loopYellow for COB
Propose to add this to OiAPS, as previously done here by @MikePlante1:
Artificial-Pancreas/iAPS#360
This PR includes a feature for uploading the branch name and git reference as a “changelog” to TestFlight, displayed under “What to Test” for each build. However , there is a bug in AppStore Connect / TestFlight, where fastlane fails to upload changelog if it was never entered before.
The workaround is to make a manual “Test Details” entry from AppStoreConnect (ASC), then build again. Then, the branch and git ref will be displayed under "What to Test" in both TestFlight and ASC.
This is a known issue, with various proposed workarounds including this one:
fastlane/fastlane#16129 (comment)
(This was originally included in another PR, but did not belong there ,hence I created this issue report instead)
Asssigned to @MikePlante1, including the required documentation :-)
The text was updated successfully, but these errors were encountered: