Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch+commit to the "What to Test" field in TestFlight #23

Closed
bjornoleh opened this issue Mar 19, 2024 · 5 comments
Closed

Add branch+commit to the "What to Test" field in TestFlight #23

bjornoleh opened this issue Mar 19, 2024 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@bjornoleh
Copy link
Contributor

Propose to add this to OiAPS, as previously done here by @MikePlante1:
Artificial-Pancreas/iAPS#360

This PR includes a feature for uploading the branch name and git reference as a “changelog” to TestFlight, displayed under “What to Test” for each build. However , there is a bug in AppStore Connect / TestFlight, where fastlane fails to upload changelog if it was never entered before.

The workaround is to make a manual “Test Details” entry from AppStoreConnect (ASC), then build again. Then, the branch and git ref will be displayed under "What to Test" in both TestFlight and ASC.

This is a known issue, with various proposed workarounds including this one:
fastlane/fastlane#16129 (comment)

(This was originally included in another PR, but did not belong there ,hence I created this issue report instead)
Asssigned to @MikePlante1, including the required documentation :-)

@bjornoleh
Copy link
Contributor Author

@sethgagnon , to get #63 merged, we should also add documentation about the workaround mentioned above. Would you like to add this to the docs?

bjornoleh pushed a commit to bjornoleh/old_trio that referenced this issue Apr 10, 2024
This was originally introduced by @MikePlante1 in iAPS
Artificial-Pancreas/iAPS#360

This PR includes a feature for uploading the branch name and git reference as a “changelog” to TestFlight, displayed under “What to Test” for each build. However , there is a bug in AppStore Connect / TestFlight, where fastlane fails to upload changelog if it was never entered before.

The workaround is to make a manual “Test Details” entry from AppStoreConnect (ASC), then build again. Then, the branch and git ref will be displayed under "What to Test" in both TestFlight and ASC.

See nightscout/Trio#23 and
nightscout/Trio#63 for details
@bjornoleh
Copy link
Contributor Author

PR #63 was targeted at the alpha-branch, and is merged there. Here is the PR to dev: #76

@bjornoleh bjornoleh changed the title Add branch+commit to "What to Test" field in TestFlight Add branch+commit to the "What to Test" field in TestFlight Apr 10, 2024
@bjornoleh bjornoleh added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 16, 2024
@bjornoleh bjornoleh added this to Trio Apr 16, 2024
@bjornoleh bjornoleh moved this to In progress in Trio Apr 16, 2024
@marionbarker
Copy link
Contributor

marionbarker commented Apr 30, 2024

I think this should be closed but deferring to @bjornoleh

@bjornoleh
Copy link
Contributor Author

@marionbarker , there is a documented way to activate the change log in TestFlight, but unfortunately it’s an unnecessarily cumbersome one. The intention was that this should go into the docs instead.:

#63 (comment)

Could l someone replace the existing one with this? And perhaps make a note that it’s optional/ non-critical for the setup of the TestFlight app

Maybe @sethgagnon could do this?

Thanks 😊

@bjornoleh
Copy link
Contributor Author

Closing this issue as completed now that @marionbarker added the easy instructions to the docs. Thanks!

nightscout/trio-docs@7d5451d

@github-project-automation github-project-automation bot moved this from In progress to Done in Trio May 1, 2024
bjornoleh added a commit that referenced this issue May 9, 2024
oref0 branch: dev - git version: e023125

Last commits:
e023125 Replace Open-iAPS with Trio (#23)
mountrcg pushed a commit to mountrcg/Trio that referenced this issue Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants