Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch name and commit hash to the "What to test" field in TestFlight #76

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

bjornoleh
Copy link
Contributor

@bjornoleh bjornoleh commented Apr 9, 2024

This was originally introduced by @MikePlante1 in iAPS Artificial-Pancreas/iAPS#360

This PR includes a feature for uploading the branch name and git reference as a “changelog” to TestFlight, displayed under “What to Test” for each build. However , there is a bug in AppStore Connect / TestFlight, where fastlane fails to upload changelog if it was never entered before.

The workaround is to make a manual “Test Details” entry from AppStoreConnect (ASC), then build again. Then, the branch and git ref will be displayed under "What to Test" in both TestFlight and ASC.

See #23 and #63 for details.

This was originally introduced by @MikePlante1 in iAPS
Artificial-Pancreas/iAPS#360

This PR includes a feature for uploading the branch name and git reference as a “changelog” to TestFlight, displayed under “What to Test” for each build. However , there is a bug in AppStore Connect / TestFlight, where fastlane fails to upload changelog if it was never entered before.

The workaround is to make a manual “Test Details” entry from AppStoreConnect (ASC), then build again. Then, the branch and git ref will be displayed under "What to Test" in both TestFlight and ASC.

See nightscout/Trio#23 and
nightscout/Trio#63 for details
@bjornoleh
Copy link
Contributor Author

A version of the workaround for the initial changelog is now documented in nightscout/trio-docs#22. Please note an easier workaround is possible too:

Screenshots from building Loop, but the same applies to all:

Click any previous build (provided you already built successfully once):
image

Then, enter something (anything) in the Test Details fiels, and hit Save.
image

The next time you build, the branch name and commit id should appear as test notes in TestFlight.

@bjornoleh bjornoleh changed the title Add branch name and commit hash to the "What to test" in TestFlight Add branch name and commit hash to the "What to test" field in TestFlight Apr 10, 2024
@bjornoleh
Copy link
Contributor Author

Tested and confirmed to work in alpha and also previously in iAPS. Merging this into dev.

@bjornoleh bjornoleh merged commit a9bda16 into nightscout:dev Apr 12, 2024
@bjornoleh bjornoleh deleted the branch-info-in-testflight branch April 12, 2024 21:44
@MikePlante1 MikePlante1 mentioned this pull request Apr 13, 2024
Sjoerd-Bo3 pushed a commit to Sjoerd-Bo3/Trio that referenced this pull request Oct 19, 2024
…les_fix_Xcode16

LibreTransmitter: SHA only, no code change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants