Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fastfile #63

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Update Fastfile #63

merged 1 commit into from
Apr 9, 2024

Conversation

sethgagnon
Copy link
Contributor

This will add branch name and commit hash to the "What to test" field in Testflight. Easy for testers to see this info when updating in Testflight.

this will add branch name and commit hash to the "What to test" field in Testflight
@sethgagnon
Copy link
Contributor Author

submitted PR#22 into docs to provide instructions for the workaround

@sethgagnon
Copy link
Contributor Author

also followed those steps in the docs PR and can now see the info in Testflight

IMG_7900

@bjornoleh
Copy link
Contributor

Merging this with reference to previous use in iAPS, and the workaround that is now documented in nightscout/trio-docs#22. Please note an easier workaround is possible too:

Screenshots from building Loop, but the same applies to all:

Click any previous build (provided you already built successfully once):
image

Then, enter something (anything) in the Test Details fiels, and hit Save.
image

The next time you build, the branch name and commit id should appear as test notes in TestFlight.

This feature was originally introduced by @MikePlante1 in iAPS
Artificial-Pancreas/iAPS#360

@bjornoleh bjornoleh merged commit e838a32 into nightscout:alpha Apr 9, 2024
bjornoleh pushed a commit to bjornoleh/old_trio that referenced this pull request Apr 10, 2024
This was originally introduced by @MikePlante1 in iAPS
Artificial-Pancreas/iAPS#360

This PR includes a feature for uploading the branch name and git reference as a “changelog” to TestFlight, displayed under “What to Test” for each build. However , there is a bug in AppStore Connect / TestFlight, where fastlane fails to upload changelog if it was never entered before.

The workaround is to make a manual “Test Details” entry from AppStoreConnect (ASC), then build again. Then, the branch and git ref will be displayed under "What to Test" in both TestFlight and ASC.

See nightscout/Trio#23 and
nightscout/Trio#63 for details
@MikePlante1 MikePlante1 mentioned this pull request Apr 16, 2024
@MikePlante1 MikePlante1 mentioned this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants