-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: restore python 2.6 in semverRange for v5.x #1912
Conversation
Python 3 is allowed as a compatible Python, but its looked for after Python 2. rvagg: removed additional EXPERIMENTAL_NODE_GYP_PYTHON3 in .travis.yml from a previous commit while landing. Backport-of: #1844 PR-URL: #1910 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: João Reis <reis@janeasystems.com>
PR-URL: #1904 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>
2388241
to
3440704
Compare
3440704
to
8250ad7
Compare
@sam-github thanks for the approval, I just pushed a change to make it |
We do not support Python 2.6, 3.0, 3.1, 3.2, 3.3, or 3.4. They are all EOL. Our Python 3 conversion code was not tested on these EOL platforms and is known to break in them. https://www.google.ch/amp/s/snarky.ca/stop-using-python-2-6/amp/ Was written by the Python Core Team four years ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I object. Python 2.6 was EoLed in 2013. https://devguide.python.org/devcycle/#end-of-life-branches This is known to fail. Please add tests on Travis and/or Jenkins to prove that each of these EoLed versions pass our tests.
Unless we know for certain that 2.6 doesn't work, shipping an update "patch" release that can cause people with working 2.6 systems to stop getting builds doesn't seem to have a point. @cclauss 6.x can forbid 2.6, why do it in 5.x? |
We don’t know anything about Python 2.6 because we do not test on it. On Travis, we should be able to dist: precise and python: 2.6 and run our tests. #1913 If they pass then I will withdrawn my objection. |
we're not going to increase the semver check from 2.6 to 2.7 on 5.x, that's one of the things 6.x is for. It was mistakenly bumped in the backport, this restores it to what it was prior to that commit. I'll remove mention of 2.6 from the docs, the semverRange check has to be restored to what it was on 5.0.4 though. |
removed mention of 2.6 in #1911, it's only "supported" in the sense that we don't reject it in our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropping my objection. Let’s wrap up v5.x and move onto v6...
Please proceed despite #1913... It is time to move forward to v6.x |
Dropped accidentally in backport @
#1910
The change to >=2.7 was declared semver-major in
#1813
@sam-github @cclauss @joaocgreis this blocks 5.0.5. If nobody disagrees I might just squash this into the commit that I landed in v5.x for #1910 as if it was right all along. It'll mean rewriting a few commits on the HEAD of v5.x.