Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: restore python 2.6 in semverRange for v5.x #1912

Closed
wants to merge 4 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 4, 2019

Dropped accidentally in backport @
#1910

The change to >=2.7 was declared semver-major in
#1813

@sam-github @cclauss @joaocgreis this blocks 5.0.5. If nobody disagrees I might just squash this into the commit that I landed in v5.x for #1910 as if it was right all along. It'll mean rewriting a few commits on the HEAD of v5.x.

sam-github and others added 3 commits October 4, 2019 13:37
Python 3 is allowed as a compatible Python, but its looked for after
Python 2.

rvagg: removed additional EXPERIMENTAL_NODE_GYP_PYTHON3 in
.travis.yml from a previous commit while landing.

Backport-of: #1844
PR-URL: #1910
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: João Reis <reis@janeasystems.com>
Fixes: #1881
PR-URL: #1902
Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #1904
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Dropped accidentally in backport @
#1910

The change to >=2.7 was declared semver-major in
#1813
@rvagg
Copy link
Member Author

rvagg commented Oct 4, 2019

@sam-github thanks for the approval, I just pushed a change to make it ^2.6.0 || >= 3.5.0, the original one allowed anything >=2.6. I'm going to assume tests passing gives me the +1 on that change unless you want to re-approve.

@cclauss
Copy link
Contributor

cclauss commented Oct 4, 2019

We do not support Python 2.6, 3.0, 3.1, 3.2, 3.3, or 3.4. They are all EOL. Our Python 3 conversion code was not tested on these EOL platforms and is known to break in them. https://www.google.ch/amp/s/snarky.ca/stop-using-python-2-6/amp/ Was written by the Python Core Team four years ago.

@cclauss cclauss self-requested a review October 4, 2019 04:36
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I object. Python 2.6 was EoLed in 2013. https://devguide.python.org/devcycle/#end-of-life-branches This is known to fail. Please add tests on Travis and/or Jenkins to prove that each of these EoLed versions pass our tests.

@sam-github
Copy link
Contributor

Unless we know for certain that 2.6 doesn't work, shipping an update "patch" release that can cause people with working 2.6 systems to stop getting builds doesn't seem to have a point.

@cclauss 6.x can forbid 2.6, why do it in 5.x?

@cclauss
Copy link
Contributor

cclauss commented Oct 4, 2019

We don’t know anything about Python 2.6 because we do not test on it.

On Travis, we should be able to dist: precise and python: 2.6 and run our tests. #1913

If they pass then I will withdrawn my objection.

@rvagg
Copy link
Member Author

rvagg commented Oct 4, 2019

we're not going to increase the semver check from 2.6 to 2.7 on 5.x, that's one of the things 6.x is for. It was mistakenly bumped in the backport, this restores it to what it was prior to that commit. I'll remove mention of 2.6 from the docs, the semverRange check has to be restored to what it was on 5.0.4 though.

@rvagg rvagg changed the title lib: restore python 2.6 compatibilty for v5.x lib: restore python 2.6 in semverRange for v5.x Oct 4, 2019
@rvagg
Copy link
Member Author

rvagg commented Oct 4, 2019

removed mention of 2.6 in #1911, it's only "supported" in the sense that we don't reject it in our semverRange, whether that works for people or not is not if we don't state that it's compatible with it. We just can't change semverRange outside of a sevmer-major.

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping my objection. Let’s wrap up v5.x and move onto v6...

@cclauss
Copy link
Contributor

cclauss commented Oct 4, 2019

Please proceed despite #1913... It is time to move forward to v6.x

@rvagg
Copy link
Member Author

rvagg commented Oct 4, 2019

squashed into the #1910 commit as 07f81f1, minor reorg of the HEAD of v5.x and force pushed up

@rvagg rvagg closed this Oct 4, 2019
@rvagg rvagg deleted the rvagg/restore-python-2.6 branch October 4, 2019 12:36
@cclauss cclauss added the Python label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants