Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.9.0 Release Proposal #12319

Merged
merged 59 commits into from
Apr 11, 2017
Merged

v7.9.0 Release Proposal #12319

merged 59 commits into from
Apr 11, 2017

Commits on Apr 10, 2017

  1. doc: add deprecations page to docs toc

    PR-URL: #12268
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    targos committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    5ac719d View commit details
    Browse the repository at this point in the history
  2. util: add %i and %f formatting specifiers

    This change brings formatting specifiers available in `util.format` and
    consequently, `console.*` closer to what is supported in all major
    browsers.
    
    - `%i` is introduced to format integer values.
    - `%f` is introduced to format floating point values.
    
    Fixes: #10292
    PR-URL: #10308
    Reviewed-By: James M Snell <jasnell@gmail.com>
    silverwind authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    1ee38eb View commit details
    Browse the repository at this point in the history
  3. deps: backport 8dde6ac from upstream V8

    Commit 9c9e2d7 changed the name of TypeFeedbackVector to
    FeedbackVector but that commit did not update gdbinit. This applies the
    changed to gdbinit from upstream V8.
    
    Original commit message:
    
    [gdbinit] Rename TypeFeedback* to Feedback*.
    
        BUG=
    
        Change-Id: I1e32fdcf9edda57f5de329c8b694620a5da4558b
        Reviewed-on: https://chromium-review.googlesource.com/442444
        Reviewed-by: Michael Stanton <mvstanton@chromium.org>
        Commit-Queue: Igor Sheludko <ishell@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#43185}
    
    PR-URL: #12060
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    danbev authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    6130d54 View commit details
    Browse the repository at this point in the history
  4. tools: add missing #include "unicode/putil.h"

    * we use u_setDataDirectory() in "unicode/putil.h"
    * at present, this header is indirectly included,
      but this will change in ICU 59
    * no impact on past ICUs.
    * this is an exact analog to #11753
    
    PR-URL: #12078
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    srl295 authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    fdf76d5 View commit details
    Browse the repository at this point in the history
  5. test: fix flaky child-process-exec-kill-throws

    This is a fix for test-child-process-exec-kill-throws which is currently
    flaky on Windows.
    
    A bug in the test was causing the child process to fail for reasons
    other than those intended by the test. Instead of failing for exceeding
    the `maxBuffer` setting, the test was failing because it was trying to
    load `internal/child_process` without being passed the
    `expose-internals` flag. Move that module to where only the parent
    process (which gets the flag) loads it.
    
    Additionally, improve an assertion message to help debug problems like
    this.
    
    PR-URL: #12111
    Fixes: #12053
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Trott authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    87ca9a6 View commit details
    Browse the repository at this point in the history
  6. tools: update dotfile whitelist in .gitignore

    .eslintrc was renamed in #7699 to .eslintrc.yaml.
    
    PR-URL: #12116
    Refs: #7699
    Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    8823861 View commit details
    Browse the repository at this point in the history
  7. src: fix base64 decoding

    Make sure trailing garbage is not treated as a valid base64 character.
    
    Fixes: #11987
    PR-URL: #11995
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    seishun authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    ffbcfdf View commit details
    Browse the repository at this point in the history
  8. vm: use SetterCallback to set func declarations

    Currently, when in strict mode, function
    declarations are copied on the sandbox by
    CopyProperties(), which is not necessary
    and will break when CP is removed.
    
    This change maintains current behavior,
    letting GlobalPropertySetterCallback
    copy functions on the sandbox instead
    of using CP to do the task.
    
    PR-URL: #12051
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    AnnaMag authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    2f88de1 View commit details
    Browse the repository at this point in the history
  9. net: rename internal functions for readability

    * Rename listen to listenInCluster
    * Rename _listen2 to _setupListenHandle
    * Remove _listen since it's a one-liner only used in one place
    * Correct comments in server.listen
    
    PR-URL: #11796
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    305f822 View commit details
    Browse the repository at this point in the history
  10. doc: add logo to README

    Adds a centered logo to the README to make it a little more festive. As
    centering is not possible in pure Markdown, a bit of HTML is used.
    
    PR-URL: #12148
    Ref: #6920
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    silverwind authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    b5283f9 View commit details
    Browse the repository at this point in the history
  11. test: synchronize WPT url setter test data

    Updates:
    + Bring tests url-setter-tests from WPT, and put it as JavaScript
    + Comment out unpassed tests
    
    Refs: web-platform-tests/wpt#5112
    Refs: #11887
    PR-URL: #12058
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    watilde authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    6ccbf38 View commit details
    Browse the repository at this point in the history
  12. test: reduce buffer size in buffer-creation test

    This test is allocating much more memory than necessary to actually
    reproduce the original problem. Lowering the amount of memory allocated
    increases performance at least in some cases and makes this test less
    likely to time out on SmartOS.
    
    PR-URL: #11177
    Ref: #10166
    
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Julien Gilli <jgilli@nodejs.org>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    thefourtheye authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    b52b3f6 View commit details
    Browse the repository at this point in the history
  13. doc, inspector: note that the host is optional

    Document that `node --inspect=${port}` is also a viable option.
    
    PR-URL: #12149
    Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    gibfahn authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    3af9101 View commit details
    Browse the repository at this point in the history
  14. build: use $(RM) in Makefile for consistency

    Also allows someone to reassign `$RM`, e.g. with `RM=rm -v` instead of
    `rm -f` (the default) should they want to. We're currently using a
    mixture of `$(RM)` and `rm -f`.
    
    There are a couple of places which aren't doing -f, have them do it for
    consistency.
    
    PR-URL: #12157
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    gibfahn authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    72a27b3 View commit details
    Browse the repository at this point in the history
  15. test: fix flaky test-child-process-exec-timeout

    At least starting with Darwin Kernel Version 16.4.0, sending a SIGTERM
    to a process that is still starting up kills it with SIGKILL instead of
    SIGTERM.
    
    PR-URL: #12159
    Refs: libuv/libuv#1226
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    santigimeno authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    b15dc95 View commit details
    Browse the repository at this point in the history
  16. benchmark: replace [].join() with ''.repeat()

    Also add a benchmark to compare both ways to create strings.
    
    PR-URL: #12170
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    vsemozhetbyt authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    f057cc3 View commit details
    Browse the repository at this point in the history
  17. doc: fix and update examples in http.md

    * replace `var` by `const` in http.md
    * replace `let` by `const` in http.md
    * fix spaces in code examples of http.md
    * replace console.log() by .error() in http.md
    * make arrow function clearer in http.md
    * use object destructuring in http.md
    * update output examples in http.md
    
    PR-URL: #12169
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    vsemozhetbyt authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    d6e9cf7 View commit details
    Browse the repository at this point in the history
  18. test: increase querystring coverage

    PR-URL: #12163
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    DavidCai1111 authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    fb34d9c View commit details
    Browse the repository at this point in the history
  19. buffer: optimize decoding wrapped base64 data

    The fast base64 decoder used to switch to the slow one permanently when
    it saw a whitespace or other garbage character.  Since the most common
    situation such characters may be encountered in is line-wrapped base64
    data, a more profitable strategy is to decode a single 24-bit group with
    the slow decoder and then continue running the fast algorithm.
    
    PR-URL: #12146
    Ref: #12114
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aqrln authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    805ebef View commit details
    Browse the repository at this point in the history
  20. test: performance, remove Popen(shell=True) on Win

    not needed according to official python docs -
    https://docs.python.org/2/library/subprocess.html#index-2
    
    PR-URL: #12138
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    refack authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    9e6b0a4 View commit details
    Browse the repository at this point in the history
  21. doc: add notes to http.get options

    Extra notes that options doesn't include the prototype when copied
    
    Fixes: #12092
    PR-URL: #12124
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    raphaelokon authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    36617fd View commit details
    Browse the repository at this point in the history
  22. doc: update Mac OS X references in releases.md

    This commit updates 3 additional references to Mac OS X in
    releases.md to macOS.
    
    PR-URL: #12106
    Fixes: #12086
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    JR McEntee authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    731a200 View commit details
    Browse the repository at this point in the history
  23. tools: update ESLint to 3.19.0

    PR-URL: #12162
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    8058bae View commit details
    Browse the repository at this point in the history
  24. events: do not keep arrays with a single listener

    Use the remaining listener directly if the array of listeners has only
    one element after running `EventEmitter.prototype.removeListener()`.
    
    Advantages:
    
    - Better memory usage and better performance if no new listeners are
      added for the same event.
    
    Disadvantages:
    
    - A new array must be created if new listeners are added for the same
      event.
    
    PR-URL: #12043
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Ron Korving <ron@ronkorving.nl>
    lpinca authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    c814c7e View commit details
    Browse the repository at this point in the history
  25. doc: fix fs.read arg type

    About fs.read's 2nd argument, string is invalid.
    
    PR-URL: #12034
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    darai0512 authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    806c4f3 View commit details
    Browse the repository at this point in the history
  26. doc: fix the timing of setImmediate's execution

    About setImmediate, the execution timing is after timers currently.
    
    PR-URL: #12034
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    darai0512 authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    cf1117b View commit details
    Browse the repository at this point in the history
  27. benchmark: avoid TurboFan deopt in arrays bench

    Something unidentified at the moment is causing the arrays benchmarks to
    deopt when run with the TurboFan compiler. Refactor the test to use an
    inner function that can be correctly optimized by TurboFan and
    Crankshaft.
    
    PR-URL: #11894
    Ref: #11851 (comment)
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    targos authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    6083e7a View commit details
    Browse the repository at this point in the history
  28. test: more robust check for location of node.exe

    look for the actual produced `exe` not just the directory
    
    PR-URL: #12120
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
    refack authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    a11ed6a View commit details
    Browse the repository at this point in the history
  29. doc: add table of contents to README.md

    PR-URL: #11635
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Minimalistic authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    961c89c View commit details
    Browse the repository at this point in the history
  30. test: add Unicode characters regression test

    This test ensures that UTF-8 characters can be used in core JavaScript
    modules built into Node's binary.
    
    PR-URL: #11423
    Ref: #11129
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aqrln authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    8caf6fd View commit details
    Browse the repository at this point in the history
  31. test: refactor mkdtemp test and added async

    This test refactored the original test for mkdtempSync prefix validation
    and added the test also for the async function mkdtemp.
    
    PR-URL: #12080
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    lucamaraschi authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    4b54520 View commit details
    Browse the repository at this point in the history
  32. doc: fix string interpolation in Stream 'finish'

    PR-URL: #12221
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    vhmth authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    74d0266 View commit details
    Browse the repository at this point in the history
  33. doc: modernize and fix code examples in https.md

    * Replace `var` by `const`.
    * Comment out ellipses.
    * Update code example (provide relevant file path, add missing option).
    
    PR-URL: #12171
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    vsemozhetbyt authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    f60b455 View commit details
    Browse the repository at this point in the history
  34. build: make configure print statements consistent

    I noticed that few of the print statements in configure have a leading
    space with is not consistent with the rest of the file. Not sure if
    this intentional or not so creating this commit just to bring it up
    just in case.
    
    PR-URL: #12176
    
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    danbev authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    b495b6a View commit details
    Browse the repository at this point in the history
  35. build: add checks for openssl configure options

    Currently it is possible to configure using --without-ssl and
    --shared-openssl/--openssl-no-asm/openssl-fips without an error
    occuring.
    
    The commit add check for these combinations:
    
    $ ./configure --without-ssl --shared-openssl
    Error: --without-ssl is incompatible with --shared-openssl
    
    $ ./configure --without-ssl --openssl-no-asm
    Error: --without-ssl is incompatible with --openssl-no-asm
    
    $ ./configure --without-ssl --openssl-fips=dummy
    Error: --without-ssl is incompatible with --openssl-fips
    
    PR-URL: #12175
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    danbev authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    a703bde View commit details
    Browse the repository at this point in the history
  36. buffer: preallocate array with buffer length

    Because the final array length is known, it's better to allocate its
    final length at initialization time to avoid future reallocations.
    
    Also add an explicit buffer length greater than 0 comparison so
    it's more readable, avoids the internal ToBoolean call and follows the
    standard Node.js API format (as it can be checked in other similar
    structures where 'length > 0' is preferred over 'length')
    
    PR-URL: #11733
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    alemures authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    6feea08 View commit details
    Browse the repository at this point in the history
  37. doc: update pull request template URL layout

    Putting the link for the commit guideline at the bottom of the pull
    request template makes it a bit confusing when opening a pull request as
    the markdown does not render. Not everyone is familiar with the syntax
    used there and it is easy to mess it up (for example, by not leaving a
    blank line above it). It is more natural and useful if the URL is
    included inline.
    
    PR-URL: #12216
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    d641164 View commit details
    Browse the repository at this point in the history
  38. deps: backport ec1ffe3 from upstream V8

    This commit adds lldbinit files from upstream V8 and also adds these so
    that they get installed when `make install` is run.
    
    Original commit message:
    
    [tools] add lldbinit
    
        The goal of this commit is to add the equivalent to gdbinit but
        for lldb. I've tried to replicate the commands as close as possible
        but I'm unsure about the jss command and hoping to get some feedback
        on it in addition to the bta command which I'm not sure how/when
        this could be used. This is probably just inexperience on my part.
    
        The lldbinit file can be placed into a directory prefixed with dot
        (.lldbinit) and the python script is currently expected to be in the
        same directory. The path to the script can be changed manually if
        needed as well.
    
        NOTRY=true
    
        Review-Url: https://codereview.chromium.org/2758373002
        Cr-Commit-Position: refs/heads/master@{#44136}
    
    PR-URL: #12061
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    danbev authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    a735c16 View commit details
    Browse the repository at this point in the history
  39. build: fix path voodoo in icu-generic.gyp

    Intention was to get to `PRODUCT_DIR` so no need to do path voodoo
    Also added `'msvs_quote_cmd': 0` and more precise quoting
    
    PR-URL: #11217
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
    refack authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    d4d6986 View commit details
    Browse the repository at this point in the history
  40. test: skip irrelevant test on Windows

    Skip test-cluster-disconnect-handles on Windows.
    
    PR-URL: #12261
    Ref: #12197 (comment)
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    3cdd04b View commit details
    Browse the repository at this point in the history
  41. test: add a second argument to assert.throws()

    - a regular expression that matches the entire error message.
    
    PR-URL: #12139
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
    dave-k authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    ac200a6 View commit details
    Browse the repository at this point in the history
  42. doc: add sub domain to host in url

    PR-URL: #12233
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    styfle authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    2fb2289 View commit details
    Browse the repository at this point in the history
  43. doc: add aqrln to collaborators

    Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md
    
    PR-URL: #12273
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aqrln authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    83f855d View commit details
    Browse the repository at this point in the history
  44. doc: add refack to collaborators

    PR-URL: #12277
    Refs: https://github.com/nodejs/node/blob/master/doc/onboarding.md
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    refack authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    c0b7c07 View commit details
    Browse the repository at this point in the history
  45. doc: document the performance team

    Can be cc'ed with `@nodejs/performance`.
    
    PR-URL: #12213
    Refs: #12194 (comment)
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    gibfahn authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    376f5ef View commit details
    Browse the repository at this point in the history
  46. doc: modernize and fix code examples in modules.md

    * Replace `var` by `const`.
    * Fix semicolons.
    * Add missing code marks.
    * Unify quotes.
    * Comment out ellipsis.
    * Use object destructuring.
    * Use exponentiation operator.
    * Replace snake_case by camelCase.
    
    PR-URL: #12224
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
    vsemozhetbyt authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    3e8991c View commit details
    Browse the repository at this point in the history
  47. doc: fix confusing reference in net.md

    PR-URL: #12247
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
    vsemozhetbyt authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    4a6bb37 View commit details
    Browse the repository at this point in the history
  48. doc: fix missing argument for dns.resolvePtr()

    PR-URL: #12256
    Fixes: #12161
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    uppinder authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    6826637 View commit details
    Browse the repository at this point in the history
  49. src: use std::string for trace enabled_categories

    A std::string manages its own memory, so using one removes the implicit
    assumption that the argv vector passed to node will never be
    deallocated. Also, the enabled_categories are used to construct a
    std::stringstream, so its simpler to use the standard library
    consistently.
    
    PR-URL: #12242
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    sam-github authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    0f4319a View commit details
    Browse the repository at this point in the history
  50. doc: update information on test/known_issues

    * Since #6559 known_issues
      does run on CI.
    * Add some notes to explain the expectations around tests in
      known_issues.
    
    PR-URL: #12262
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Jan Krems authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    2f9e2fc View commit details
    Browse the repository at this point in the history
  51. src: use std::list for at_exit_functions

    This change was suggested by bnoordhuis in the following comment:
    #9163 (comment)
    
    Not including any tests as this is covered by test/addons/at-exit.
    
    PR-URL: #12255
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    danbev authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    37568c0 View commit details
    Browse the repository at this point in the history
  52. doc: fix confusing example in process.md

    PR-URL: #12282
    Fixes: #12280
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    vsemozhetbyt authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    3b765f5 View commit details
    Browse the repository at this point in the history
  53. crypto: handle exceptions in hmac/hash.digest

    Forced conversion of the encoding parameter to a string within
    crypto.js, fixing segmentation faults in node_crypto.cc.
    
    Fixes: #9819
    PR-URL: #12164
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    67d2114 View commit details
    Browse the repository at this point in the history
  54. doc: make the heading consistent

    All the other headings are in level 3. This patch fixes the offending
    heading to use level 3.
    
    PR-URL: #11569
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    thefourtheye authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    c11c23b View commit details
    Browse the repository at this point in the history
  55. test: add internal/socket_list tests

    PR-URL: #12109
    Reviewed-By: James M Snell <jasnell@gmail.com>
    DavidCai1111 authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    b997e62 View commit details
    Browse the repository at this point in the history
  56. tools: ignore URLs in line length linting

    Where inclusion of a lengthy URL causes a line to exceed 80 characters
    in our code base, do not report the line length as a linting error.
    
    PR-URL: #11890
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Trott authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    77353b3 View commit details
    Browse the repository at this point in the history
  57. benchmark: add final clean-up to module-loader.js

    PR-URL: #12102
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    vsemozhetbyt authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    211dd16 View commit details
    Browse the repository at this point in the history
  58. deps: cherry-pick 22858cb from V8 upstream

    Original commit message:
      Only flush not yet started and finished compile jobs from gc
    
      We shouldn't block during GC for arbitrarily long intervals.
    
      BUG=chromium:686153,chromium:642532
      R=verwaest@chromium.org,hpayer@chromium.org
    
      Review-Url: https://codereview.chromium.org/2658313002
      Cr-Commit-Position: refs/heads/master@{#42761}
    
    PR-URL: #11998
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ofrobots authored and italoacasas committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    9f73df5 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2017

  1. 2017-04-11, Version 7.9.0 (Current)

    Notable changes:
    
    * util: console is now closer to what is supported in all major browsers
    (Roman Reiss) [#10308](#10308)
    
    PR-URL: #12319
    italoacasas committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    0794478 View commit details
    Browse the repository at this point in the history