-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: avoid std::make_unique
#20386
src: avoid std::make_unique
#20386
Conversation
Work around nodejs/build#1254, which effectively breaks stress test CI and CITGM, by avoiding `std::make_unique` for now. This workaround should be reverted once that issue is resolved. Refs: nodejs/build#1254
Wasn’t sure about whether to open this PR, but I have no idea how soon the build issue is resolved and I think we want at least CITGM to be available for now – please 👍 this comment if you agree with fast-tracking. |
Here’s a re-run of the stress test CI that I originally wanted to run, to be sure: Stress CI (master): https://ci.nodejs.org/job/node-stress-single-test/1827/ |
Landed in 283a967 |
Work around nodejs/build#1254, which effectively breaks stress test CI and CITGM, by avoiding `std::make_unique` for now. This workaround should be reverted once that issue is resolved. Refs: nodejs/build#1254 PR-URL: #20386 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com>
Work around nodejs/build#1254, which effectively breaks stress test CI and CITGM, by avoiding `std::make_unique` for now. This workaround should be reverted once that issue is resolved. Refs: nodejs/build#1254 PR-URL: #20386 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com>
This broke Travis CI. We have run into this problem with `std::make_unique` in the past, and opted to not use it for now, e.g. in nodejs#20386.
Work around nodejs/build#1254, which
effectively breaks stress test CI and CITGM, by avoiding
std::make_unique
for now.This workaround should be reverted once that issue is resolved.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes