Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: avoid std::make_unique for now #23856

Closed
wants to merge 1 commit into from
Closed

src: avoid std::make_unique for now #23856

wants to merge 1 commit into from
+1 −1

Conversation

addaleax
Copy link
Member

This broke Travis CI. We have run into this problem with
std::make_unique in the past, and opted to not use it
for now, e.g. in #20386.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: avoid std::make_unique for now
b669f96 
This broke Travis CI. We have run into this problem with
`std::make_unique` in the past, and opted to not use it
for now, e.g. in nodejs#20386.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1360/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 24, 2018
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 24, 2018
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/18124/

Feel free to 👍 this comment to approve fast-tracking.

eugeneo
eugeneo approved these changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭
AFAIR, in the past it was caused by AIX bot using unsupported (by Node.js) compiler. Is there a tracking bug for that issue?

@refack refack removed the fast-track PRs that do not need to wait for 48 hours to land. label Oct 24, 2018
@addaleax
Copy link
Member Author

@eugeneo I think #23778 would take care of updating the compiler on Travis CI? I’d be happy to have that resolve this as well (I don’t like how it slips in unrelated changes but that’s another story).

@refack
Copy link
Contributor

refack commented Oct 24, 2018

I believe this should be fixed by using the minimal supported compiler, i.e. #23778.

@addaleax
Copy link
Member Author

@refack If that PR is close to landing and addresses the issue, sure. It didn’t look that way from your most recents comments, though?

@refack
Copy link
Contributor

refack commented Oct 24, 2018

#23778 landed.

@addaleax
Copy link
Member Author

Okay, I guess we can close this then.

@addaleax addaleax closed this Oct 25, 2018
@addaleax addaleax deleted the no-make-unique branch October 25, 2018 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

@eugeneo eugeneo eugeneo approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @refack @eugeneo @jasnell @TimothyGu