v15.8.0 release proposal #37183
Merged
v15.8.0 release proposal #37183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements initial experimental support for Curve25519 and Curve448 support for both ECDH and sign/verify in Web Crypto. Introduced as a Node.js-specific extension to Web Crypto. Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: #36076 PR-URL: #36879 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
PR-URL: #36983 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #36995 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37010 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The function makeCallback already calls validateCallback, so the call inside copyFile can be removed. PR-URL: #36984 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #36993 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37006 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Using new AbortController, add support for promisified exec to be cancelled. PR-URL: #34249 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
In some cases a question asked needs to be canceled. For instance it might be desirable to cancel a question when a user presses ctrl+c and triggers the SIGINT event. Also an initial empty string was set for this.line since the cursor methods fail if line is not initialized. Added custom promisify support to the question method. PR-URL: #33676 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #37017 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #37016 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Add tests for mode passed as an options object in fs.mkdir() and fs.mkdirSync(). This also adds coverage for mkdirSync() inside the conditional where options.mode is not undefined. PR-URL: #37008 Refs: https://coverage.nodejs.org/coverage-e3e054d020ee5ef6/lib/fs.js.html#L1023 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Show more information when the test fails. PR-URL: #36996 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
The button for toggling light mode and dark mode has no text display. Screen readers will read it as simply "button", making it not useful. Add an aria-label attribute so it gets a better description. PR-URL: #37031 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #37013 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36939 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36975 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Setting the timeout to 300s (or 5 minutes) instead of the default 120s per test to limit the number of false negative on GH Action CI results. PR-URL: #37007 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37032 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Add a history event which is emitted when the history has been changed. This enables persisting of the history in some way but also to allows a listener to alter the history. One use-case could be to prevent passwords from ending up in the history. A constructor option is also added to allow for setting an initial history list when creating a Readline interface. PR-URL: #33662 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37039 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37012 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1. Signal aborted while writing file Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L278 2. Signal aborted on first tick Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L301 3. Validate file size is withing range for reading Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L312 4. Signal aborted right before buffer read Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L321 5. Use fallback buffer allocation when input not buffer Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L374 6. Specify symlink type Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L539 7. Set modification times with lutimes Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L635 8. Use fallback encoding when input is null Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L665 9. Use fallback flag when input is null Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L681 PR-URL: #36813 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37059 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37038 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #37048 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #36946 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37026 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
The test is unreliable in CI. It might be helpful to get an exact read of `rss` so this adds that to the assertion message. PR-URL: #37034 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Added #37185 |
|
Release build: https://ci-release.nodejs.org/job/iojs+release/6638/ |
|
Is it too late to |
|
For today, yes. But if @nodejs/npm prefers to include that version I can do the release tomorrow |
|
@targos circled back with the rest of the @nodejs/npm team and the consensus is there's no reason to postpone the release for that! 😄 |
targos
added a commit
that referenced
this pull request
Feb 2, 2021
Notable changes: crypto: * (SEMVER-MINOR) add generatePrime/checkPrime (James M Snell) #36997 * (SEMVER-MINOR) experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) #36879 deps: * upgrade npm to 7.5.0 (Ruy Adorno) #37117 dgram: * (SEMVER-MINOR) support AbortSignal in createSocket (Nitzan Uziely) #37026 doc: * add Zijian Liu to collaborators (ZiJian Liu) #37075 esm: * deprecate legacy main lookup for modules (Guy Bedford) #36918 readline: * (SEMVER-MINOR) add history event and option to set initial history (Mattias Runge-Broberg) #33662 * (SEMVER-MINOR) add support for the AbortController to the question method (Mattias Runge-Broberg) #33676 PR-URL: #37183
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 2, 2021
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 2, 2021
|
🎉 |
targos
removed
build
This was referenced Jan 13, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-02-02, Version 15.8.0 (Current), @targos
Notable Changes
110063d694] - (SEMVER-MINOR) crypto: add generatePrime/checkPrime (James M Snell) #3699753a0bdff47] - (SEMVER-MINOR) crypto: experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) #3687903460432af] - deps: upgrade npm to 7.5.0 (Ruy Adorno) #37117npm diffcommand.2c7ad38c75] - (SEMVER-MINOR) dgram: support AbortSignal in createSocket (Nitzan Uziely) #37026b7c3f99f7e] - doc: add Zijian Liu to collaborators (ZiJian Liu) #3707502f1d2fda4] - esm: deprecate legacy main lookup for modules (Guy Bedford) #3691875124298d5] - (SEMVER-MINOR) readline: add history event and option to set initial history (Mattias Runge-Broberg) #336624e757eab96] - (SEMVER-MINOR) readline: add support for the AbortController to the question method (Mattias Runge-Broberg) #33676Commits
602aaf25af] - async_hooks: refactor to avoid unsafe array iteration (Antoine du Hamel) #37125dcd34b0144] - benchmark: add benchmark for NODE_V8_COVERAGE (Benjamin Coe) #36972ec22756ac9] - benchmark: make output RFC 4180 compliant (Tobias Nießen) #3703896cec1e5f3] - benchmark: improve explanations in R script (Tobias Nießen) #36995e4b88b521a] - buffer: avoid creating the backing store in the thread (James M Snell) #370527b78c6773d] - child_process: allow promisified exec to be cancel (Carlos Fuentes) #34249c4193ba8ae] - crypto: fix encrypted private -> public import (Tobias Nießen) #37056cb3b0ec4fc] - crypto: generateKeyPair('ec') should not support NODE-ED* and NODE-X* (Filip Skokan) #37063110063d694] - (SEMVER-MINOR) crypto: add generatePrime/checkPrime (James M Snell) #36997ab64d74791] - crypto: throw error on invalid object in diffieHellman() (ZiJian Liu) #3701653a0bdff47] - (SEMVER-MINOR) crypto: experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) #368794551d14b8e] - deps: upgrade npm to 7.5.1 (Ruy Adorno) #371779d6fd4586f] - deps: update openssl config (James M Snell) #37067f74b376596] - Revert "deps: various quic patches from akamai/openssl" (James M Snell) #370676756130c4b] - Revert "deps: re-enable OPENSSL_NO_QUIC guards" (James M Snell) #3706752ce1d5f1a] - Revert "deps: update patch and docs for openssl update" (James M Snell) #3706703460432af] - deps: upgrade npm to 7.5.0 (Ruy Adorno) #371172c7ad38c75] - (SEMVER-MINOR) dgram: support AbortSignal in createSocket (Nitzan Uziely) #3702647bfde00fd] - doc: fix color contrast on <kbd> elements (Antoine du Hamel) #371853c9077130d] - doc: fix list format in Developer's Certificate of Origin (Akash Negi) #371388cecce3ff4] - doc: fix markup and alphabetization in errors.md (Rich Trott) #37144a7780815bf] - doc: clarify ERR_INVALID_REPL_INPUT usage (Rich Trott) #37143e7126503e0] - doc: clarify repl exception conditions (Rich Trott) #37142e55d3d0953] - doc: add example for test structure (Turner Jabbour) #350469b9a1801ba] - doc: remove TOC summary for pages with no TOC (Rich Trott) #37043ae42658be9] - doc: add missing deprecation code (Colin Ihrig) #37147b79b82de8e] - doc: update Buffer encoding option count (Dave Cardwell) #37102ddee21b587] - doc: update BUILDING.md previous versions links (Richard Lau) #370821710016053] - doc: mention adding Fixes to collaborator onboarding PR (Joyee Cheung) #37097b7c3f99f7e] - doc: add Zijian Liu to collaborators (ZiJian Liu) #370757ddfa81612] - doc: add tooltip for light/dark mode toggle (Rich Trott) #37044c79688ffe3] - doc: improve AsyncLocalStorage introduction (Romuald Brillout) #36946a7b6464097] - doc:EventTargetandEventare available to user code since v15.0.0 (ExE Boss) #370593722c15a75] - doc: add missing comma in tty (Matthew Mario Di Pasquale) #370392cfe7954fc] - doc: list Unsupported Directory Import resolve err (Guy Bedford) #37032fef6ac77e5] - doc: add missing ARIA label for button (Rich Trott) #37031634bedcd6f] - doc,test: fix prime generation description (Tobias Nießen) #37085181719d4c4] - esm: update to correct deprecation code (Colin Ihrig) #3714702f1d2fda4] - esm: deprecate legacy main lookup for modules (Guy Bedford) #3691869402522fd] - fs: read full size if known in promises.readFile (Anna Henningsen) #37127ad12fefcb0] - fs: only use Buffer.concat in promises.readFile when necessary (Anna Henningsen) #371276f54a14cda] - fs: add validatePosition and use in read and readSync (Darshan Sen) #37051175f6f0be3] - fs: use throwIfNoEntry option on statSync calls (Antoine du Hamel) #3697597fc7d8396] - fs: refactor to remove redundant validation (Darshan Sen) #369840129a79d0a] - fs: add explicit note about undefined path when recursive (Sebastian Silbermann) #370107196ac19c1] - http: refactor to avoid unsafe array iteration (Antoine du Hamel) #37124ed58065d1f] - lib: addbound applyvariants of varargsprimordials(ExE Boss) #3700567b58f68c9] - lib: refactor to use validateObject (ZiJian Liu) #370285227c5e6f5] - lib: refactor to use validateFunction (ZiJian Liu) #3704534adf7f74b] - lib: refactor to avoid unsafe array iteration (Antoine du Hamel) #370294a1fc42178] - lib: refactor to use optional chaining in internal/options.js (raisinten) #36939d76400a264] - lib: refactor to use validateString (ZiJian Liu) #37006a29da64b46] - lib: refactor to use validateNumber (ZiJian Liu) #3699356377d6cee] - lib: support returning Safe collections from C++ (ExE Boss) #36989c4cab1f408] - lib: refactor to use validateBoolean (ZiJian Liu) #3698311dd2672cd] - quic: remove quic (James M Snell) #37067b533485f32] - quic: remove duplicate checks (ZiJian Liu) #370171714998e2c] - readline: replace _questionCancel with a symbol (Colin Ihrig) #370943d64d2b5ef] - readline: check for null input in question() (Colin Ihrig) #3708975124298d5] - (SEMVER-MINOR) readline: add history event and option to set initial history (Mattias Runge-Broberg) #336624e757eab96] - (SEMVER-MINOR) readline: add support for the AbortController to the question method (Mattias Runge-Broberg) #33676a26dfb323b] - src: expose BaseObject::kInternalFieldCount in post-mortem metadata (Joyee Cheung) #371119c831c0d8f] - src: fix dead code in RandomPrimeTraits (Tobias Nießen) #3708381e9acf242] - src: rename crypto_ecdh.(h|cc) to crypto_ec.(h|cc) (Tobias Nießen) #370481f819ec47d] - test: add tests forbound applyvariants of varargsprimordials(ExE Boss) #37005db38cf27c2] - test: increase inspect coverage (Emil Sivervik) #3675510da5c1104] - test: skip tests consistently in parallel.status (Rich Trott) #37035da07eb654e] - test: increase read file abort coverage (Moshe vilner) #3671655407b826f] - test: update to improve terminology (Michael Dawson) #37011ef2b25088d] - test: increase coverage for assert/calltracker (ZiJian Liu) #36728074641c2e9] - test: improve assertion message for test-vm-memleak (Rich Trott) #370344086b230b8] - test: increase fs promise coverage (Emil Sivervik) #3681394204f7e46] - test: process.nextTick for before exit (ttzztztz) #370122135618052] - test: increase timeout on ASAN Action (Antoine du Hamel) #37007de6dca12e8] - test: improve coverage ofSourceTextModulegetters (Juan José Arboleda) #3701336cc8df358] - test: log error in test-fs-realpath-pipe (Joyee Cheung) #3699636930e4fe7] - test: test mode passed as an options object in mkdir/mkdirSync (Darshan Sen) #370089c69ca5e54] - test,doc,lib: adjust object literal newlines for lint rule (Rich Trott) #37040fe9f4fdba5] - tools: remove commented code from stability.js (Colin Ihrig) #37092d2d6121f3e] - tools: enable object-curly-newline in ESLint rules (Rich Trott) #370403187845980] - util: add internal createDeferredPromise() (Colin Ihrig) #37095