Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v18.x backport] sea: allow requiring core modules with the "node:" prefix #49648

Closed

Commits on Sep 12, 2023

  1. http: server add async dispose

    PR-URL: nodejs#48548
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    fcd0424 View commit details
    Browse the repository at this point in the history
  2. http2: server add asyncDispose

    PR-URL: nodejs#48548
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    7a00bda View commit details
    Browse the repository at this point in the history
  3. deps: update acorn to 8.9.0

    PR-URL: nodejs#48484
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    a9711bb View commit details
    Browse the repository at this point in the history
  4. doc: update security release stewards

    PR-URL: nodejs#48569
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    RafaelGSS authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c4e8b51 View commit details
    Browse the repository at this point in the history
  5. test: add missing assertions to test-runner-cli

    PR-URL: nodejs#48593
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    MoLow authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    dbca197 View commit details
    Browse the repository at this point in the history
  6. http: null the joinDuplicateHeaders property on cleanup

    Null the `joinDuplicateHeaders` property when the parser is freed.
    
    Refs: nodejs#45982
    PR-URL: nodejs#48608
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    lpinca authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    eb4550a View commit details
    Browse the repository at this point in the history
  7. doc: fix options order

    Move the `joinDuplicateHeaders` option to the correct alphabetical
    order.
    
    PR-URL: nodejs#48617
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    lpinca authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    61231c2 View commit details
    Browse the repository at this point in the history
  8. test_runner: fixed test shorthands return type

    `test.todo`, `test.only` and `test.skip` are expected to return the
    same as `test`. This commit corrects the inconsistent behavior of
    these shorthands.
    
    Fixes: nodejs#48557
    PR-URL: nodejs#48555
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    shockerqt authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    3fc8004 View commit details
    Browse the repository at this point in the history
  9. src: fix uninitialized field access in AsyncHooks

    Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
    PR-URL: nodejs#48566
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    2 people authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    31ec622 View commit details
    Browse the repository at this point in the history
  10. src: deduplicate X509 getter implementations

    Reorder arguments of internal helper functions such that their order is
    consistent across X509 property getters. Add ReturnPropertyThroughBIO()
    and ReturnProperty(). Use these new helpers to deduplicate code across
    various X509 property getters.
    
    PR-URL: nodejs#48563
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Alba Mendez <me@alba.sh>
    tniessen authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    f02e23c View commit details
    Browse the repository at this point in the history
  11. meta: bump github/codeql-action from 2.3.6 to 2.20.1

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.3.6 to 2.20.1.
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@83f0fe6...f6e388e)
    
    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: nodejs#48627
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    dependabot[bot] authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    3146327 View commit details
    Browse the repository at this point in the history
  12. meta: bump ossf/scorecard-action from 2.1.3 to 2.2.0

    Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.3 to 2.2.0.
    - [Release notes](https://github.com/ossf/scorecard-action/releases)
    - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
    - [Commits](ossf/scorecard-action@80e868c...08b4669)
    
    ---
    updated-dependencies:
    - dependency-name: ossf/scorecard-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: nodejs#48628
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    dependabot[bot] authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0b3fd8e View commit details
    Browse the repository at this point in the history
  13. meta: bump step-security/harden-runner from 2.4.0 to 2.4.1

    Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.4.0 to 2.4.1.
    - [Release notes](https://github.com/step-security/harden-runner/releases)
    - [Commits](step-security/harden-runner@128a634...55d479f)
    
    ---
    updated-dependencies:
    - dependency-name: step-security/harden-runner
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: nodejs#48626
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    dependabot[bot] authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c0e025c View commit details
    Browse the repository at this point in the history
  14. tools: update lint-md-dependencies to rollup@3.26.0

    PR-URL: nodejs#48631
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    609804d View commit details
    Browse the repository at this point in the history
  15. tools: update eslint to 8.44.0

    PR-URL: nodejs#48632
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c77d9c8 View commit details
    Browse the repository at this point in the history
  16. meta: bump actions/checkout from 3.5.2 to 3.5.3

    Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.2 to 3.5.3.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@8e5e7e5...c85c95e)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: nodejs#48625
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    dependabot[bot] authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    7826d36 View commit details
    Browse the repository at this point in the history
  17. child_process: support Symbol.dispose

    PR-URL: nodejs#48551
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    535de5a View commit details
    Browse the repository at this point in the history
  18. Revert "test: remove test-crypto-keygen flaky designation"

    This reverts commit 893c000.
    
    Refs: nodejs#48575 (comment)
    PR-URL: nodejs#48652
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    lpinca authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0b62218 View commit details
    Browse the repository at this point in the history
  19. events: allow safely adding listener to abortSignal

    PR-URL: nodejs#48596
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    atlowChemi authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0a3ae9f View commit details
    Browse the repository at this point in the history
  20. http2: send RST code 8 on AbortController signal

    Fixes: nodejs#47321
    Refs: https://www.rfc-editor.org/rfc/rfc7540#section-7
    PR-URL: nodejs#48573
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    devm33 authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    71da5dc View commit details
    Browse the repository at this point in the history
  21. doc: mention git node release prepare

    Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
    PR-URL: nodejs#48644
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    RafaelGSS authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0d544b4 View commit details
    Browse the repository at this point in the history
  22. doc: clarify transform._transform() callback argument logic

    Clarify that `transform._transform()` callback second argument is
    used only if the first argument is `null`, i.e. no error occured
    processing the chunk.
    
    PR-URL: nodejs#48680
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    rafasofizada authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    616ecf0 View commit details
    Browse the repository at this point in the history
  23. events: fix bug listenerCount don't compare wrapped listener

    When add listener by once, it will be wrapped into another function.
    And when pass listener and there is just one event listener added by
    once, it will return 0 even if passed listener equal wrapped event
    listener.
    
    Refs: nodejs#46523
    PR-URL: nodejs#48592
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    yuzheng14 authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    caccc61 View commit details
    Browse the repository at this point in the history
  24. src: remove kEagerCompile for CompileFunction

    It wasn't doing anything, and actually enabling it would cause some
    tests to fail.
    
    Refs: nodejs#48576
    PR-URL: nodejs#48671
    Refs: v8/v8@cb00db4
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    kvakil authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0de99d2 View commit details
    Browse the repository at this point in the history
  25. deps: V8: cherry-pick cb00db4dba6c

    Original commit message:
    
        [compiler] fix CompileFunction ignoring kEagerCompile
    
        v8::ScriptCompiler::CompileFunction was ignoring kEagerCompile. Unlike
        the other functions in v8::ScriptCompiler, it was not actually
        propagating kEagerCompile to the parser. The newly updated test fails
        without this change.
    
        I did some archeology and found that this was commented out since the
        original CL in https://crrev.com/c/980944.
    
        As far as I know Node.js is the main consumer of this particular API.
        This CL speeds up Node.js's overall startup time by ~13%.
    
        Change-Id: Ifc3cd6653555194d46ca48db14f7ba7a4afe0053
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4571822
        Commit-Queue: Marja Hölttä <marja@chromium.org>
        Reviewed-by: Marja Hölttä <marja@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#87944}
    
    Refs: v8/v8@cb00db4
    PR-URL: nodejs#48671
    Refs: nodejs#48576
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    kvakil authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    222082d View commit details
    Browse the repository at this point in the history
  26. tools: update lint-md-dependencies to rollup@3.26.2

    PR-URL: nodejs#48705
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    2713de6 View commit details
    Browse the repository at this point in the history
  27. tools: update doc to unist-util-select@5.0.0 unist-util-visit@5.0.0

    PR-URL: nodejs#48714
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    03b7163 View commit details
    Browse the repository at this point in the history
  28. esm: fix emit deprecation on legacy main resolve

    PR-URL: nodejs#48664
    Refs: nodejs#48325
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    aduh95 authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5861589 View commit details
    Browse the repository at this point in the history
  29. http2: use addAbortListener

    PR-URL: nodejs#48550
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    627bc92 View commit details
    Browse the repository at this point in the history
  30. readline: use addAbortListener

    PR-URL: nodejs#48550
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    b5c7634 View commit details
    Browse the repository at this point in the history
  31. stream: use addAbortListener

    PR-URL: nodejs#48550
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c44413d View commit details
    Browse the repository at this point in the history
  32. dgram: use addAbortListener

    PR-URL: nodejs#48550
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    cfeee51 View commit details
    Browse the repository at this point in the history
  33. child_process: use addAbortListener

    PR-URL: nodejs#48550
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    24eeae3 View commit details
    Browse the repository at this point in the history
  34. lib: use addAbortListener

    PR-URL: nodejs#48550
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    33c9cea View commit details
    Browse the repository at this point in the history
  35. dgram: socket add asyncDispose

    PR-URL: nodejs#48717
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    bf75a11 View commit details
    Browse the repository at this point in the history
  36. net: server add asyncDispose

    PR-URL: nodejs#48717
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    45c7e5e View commit details
    Browse the repository at this point in the history
  37. test: move test-net-throttle to parallel

    The test is not very resource intensive. It just writes data to a TCP
    socket until backpressure is reached. Move it parallel.
    
    PR-URL: nodejs#48599
    Fixes: nodejs#40507
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    lpinca authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    48f292d View commit details
    Browse the repository at this point in the history
  38. test: deflake test-net-throttle

    Sometimes the test completes with only two data chunks received on the
    client.
    
    Fixes: nodejs#40507
    PR-URL: nodejs#48599
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    lpinca authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    fcdcf1a View commit details
    Browse the repository at this point in the history
  39. deps: update acorn to 8.10.0

    PR-URL: nodejs#48713
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5c2b200 View commit details
    Browse the repository at this point in the history
  40. fs, stream: initial Symbol.dispose and Symbol.asyncDispose support

    Co-authored-by: Benjamin Gruenbaum <benjamingr@gmail.com>
    PR-URL: nodejs#48518
    Backport-PR-URL: nodejs#49598
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    2 people authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    eed884b View commit details
    Browse the repository at this point in the history
  41. deps: upgrade to libuv 1.45.0

    - linux: introduce io_uring support libuv/libuv#3952
    - src: add new metrics APIs libuv/libuv#3749
    - unix,win: give thread pool threads an 8 MB stack libuv/libuv#3787
    - win,unix: change execution order of timers libuv/libuv#3927
    
    Fixes: nodejs#43931
    Fixes: nodejs#42496
    Fixes: nodejs#47715
    Fixes: nodejs#47259
    Fixes: nodejs#47241
    PR-URL: nodejs#48078
    Backport-PR-URL: nodejs#49591
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    santigimeno authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4ee7f44 View commit details
    Browse the repository at this point in the history
  42. deps: upgrade to libuv 1.46.0

    Notable changes
    - fs: use WTF-8 on Windows: libuv/libuv#2970
    - linux: add some more iouring backed fs ops: libuv/libuv#4012
    
    Important bugs fixed
    - linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
    - src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048
    
    PR-URL: nodejs#48618
    Backport-PR-URL: nodejs#49591
    Fixes: nodejs#48512
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    PR-URL: nodejs#48078
    santigimeno authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0ed29c0 View commit details
    Browse the repository at this point in the history
  43. build: sync libuv header change

    PR-URL: nodejs#48429
    Backport-PR-URL: nodejs#49591
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    PR-URL: nodejs#48078
    gengjiawen authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4b0c098 View commit details
    Browse the repository at this point in the history
  44. deps: add missing thread-common.c in uv.gyp

    PR-URL: nodejs#49410
    Backport-PR-URL: nodejs#49591
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    PR-URL: nodejs#48078
    santigimeno authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    34a9a3c View commit details
    Browse the repository at this point in the history
  45. timers: support Symbol.dispose

    PR-URL: nodejs#48633
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    MoLow authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    959b0c2 View commit details
    Browse the repository at this point in the history
  46. test: mark test-http-regr-nodejsgh-2928 as flaky

    It has been flaky for more than a year. Mark it as flaky to avoid
    blocking the CI.
    
    PR-URL: nodejs#49565
    Refs: nodejs/reliability#658
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    joyeecheung authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5579177 View commit details
    Browse the repository at this point in the history
  47. doc: add release key for Ulises Gascon

    PR-URL: nodejs#49196
    Refs: nodejs/Release#892
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    UlisesGascon authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e1098dd View commit details
    Browse the repository at this point in the history
  48. doc: fix ambiguity in http.md and https.md

    PR-URL: nodejs#48692
    Fixes: nodejs#48688
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    an5er authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    72a7fcc View commit details
    Browse the repository at this point in the history
  49. tools: run fetch_deps.py with Python 3

    Python 3 is now required to run `gclient`. Run `tools/v8/fetch_deps.py`,
    which spawns `glient`, with Python 3.
    
    PR-URL: nodejs#48729
    Fixes: nodejs#48728
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    richardlau authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    98663a9 View commit details
    Browse the repository at this point in the history
  50. build: do not pass target toolchain flags to host toolchain

    Fixes target toolchain arguments being passed to the host toolchain when
    cross-compiling. For example, -m64 is not available on aarch64.
    
    PR-URL: nodejs#48597
    Reviewed-By: Richard Lau <rlau@redhat.com>
    tie authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    47be64c View commit details
    Browse the repository at this point in the history
  51. src: make BaseObject iteration order deterministic

    Previously we just rely on the unordered_set order to iterate over
    the BaseObjects, which is not deterministic.
    
    The iteration is only used in printing, verification, and snapshot
    generation. In the first two cases the performance overhead of
    sorting does not matter because they are only used for debugging.
    In the last case the determinism is more important than the trivial
    overhead of sorting. So this patch makes the iteration deterministic
    by sorting the set first, as what is already being done when we
    drain the queue.
    
    PR-URL: nodejs#48702
    Refs: nodejs/build#3043
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    joyeecheung authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    1989bcd View commit details
    Browse the repository at this point in the history
  52. deps: update minimatch to 9.0.3

    PR-URL: nodejs#48704
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    6dcba08 View commit details
    Browse the repository at this point in the history
  53. doc: add atlowChemi to collaborators

    PR-URL: nodejs#48757
    Fixes: nodejs#48603
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    atlowChemi authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    76c9f35 View commit details
    Browse the repository at this point in the history
  54. permission: add debug log when inserting fs nodes

    Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
    PR-URL: nodejs#48677
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    RafaelGSS authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    07eac0d View commit details
    Browse the repository at this point in the history
  55. test: fix flaky test-string-decode.js on x86

    Removes flakiness from the mentioned test due to the x86 memory limit
    
    PR-URL: nodejs#48750
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    StefanStojanovic authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    1e87ce9 View commit details
    Browse the repository at this point in the history
  56. child_process: harden against prototype pollution

    PR-URL: nodejs#48726
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    LiviaMedeiros authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    ee024cf View commit details
    Browse the repository at this point in the history
  57. deps: update nghttp2 to 1.55.0

    PR-URL: nodejs#48746
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    af9064d View commit details
    Browse the repository at this point in the history
  58. permission: fix data types in PrintTree

    * The first argument `node` should be a const pointer.
    * The second argument `spaces` should not be a signed integer type.
    * The local variable `child` should be size_t.
    * The local variable `pair` in the range declaration should be a
      reference type to avoid copying the object.
    
    Refs: nodejs#48677
    PR-URL: nodejs#48770
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    tniessen authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    817b59c View commit details
    Browse the repository at this point in the history
  59. doc: expand on squashing and rebasing to land a PR

    PR-URL: nodejs#48751
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    legendecas authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    10495ad View commit details
    Browse the repository at this point in the history
  60. util: use primordials.ArrayPrototypeIndexOf instead of mutable method

    PR-URL: nodejs#48586
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    DaisyDogs07 authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    66fb032 View commit details
    Browse the repository at this point in the history
  61. crypto: update root certificates to NSS 3.93

    This is the certdata.txt[0] from NSS 3.93, released on 2023-06-29.
    
    This is the version of NSS that shipped in Firefox 116 on
    2023-08-01.
    
    Certificates added:
    - Sectigo Public Server Authentication Root E46
    - Sectigo Public Server Authentication Root R46
    - SSL.com TLS RSA Root CA 2022
    - SSL.com TLS ECC Root CA 2022
    - Atos TrustedRoot Root CA ECC TLS 2021
    - Atos TrustedRoot Root CA RSA TLS 2021
    
    Certificates removed:
    - Hongkong Post Root CA 1
    - E-Tugra Certification Authority
    - E-Tugra Global Root CA RSA v3
    - E-Tugra Global Root CA ECC v3
    
    [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_93_RTM/lib/ckfw/builtins/certdata.txt
    
    PR-URL: nodejs#49341
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    nodejs-github-bot authored and ruyadorno committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    ef85828 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. sea: allow requiring core modules with the "node:" prefix

    Previously, the `require()` function exposed to the embedded SEA code
    was calling the internal `require()` function if the module name
    belonged to the list of public core modules but the internal `require()`
    function does not support loading modules with the "node:" prefix, so
    this change forwards the calls to another `require()` function that
    supports this.
    
    Fixes: nodejs/single-executable#69
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: nodejs#47779
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    RaisinTen committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    003f6ba View commit details
    Browse the repository at this point in the history