Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow warnings by default #1383

Merged
merged 1 commit into from
May 23, 2023
Merged

feat: Allow warnings by default #1383

merged 1 commit into from
May 23, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented May 22, 2023

Related issue(s)

Resolves #1382

Description

Summary of changes

Allows warnings by default. The old default behavior of treating warnings like errors is now opt-in with the --deny-warnings flag. The old --allow-warnings flag has been removed as it is no longer useful.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

We should remove references to --allow-warnings in the documentation and add references to --deny-warnings. Additionally, we should mention that unused variables are warnings rather than errors if we mention them at all. Deprecated constructs like constrain do not need to be mentioned.

Additional context

@jfecher jfecher requested a review from joss-aztec May 22, 2023 17:10
Copy link
Contributor

@joss-aztec joss-aztec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joss-aztec joss-aztec added this pull request to the merge queue May 23, 2023
Merged via the queue into master with commit e7a0d5c May 23, 2023
@joss-aztec joss-aztec deleted the jf/warnings branch May 23, 2023 09:29
TomAFrench added a commit that referenced this pull request May 24, 2023
* master:
  chore(ssa refactor): Add loop unrolling pass (#1364)
  chore: Add terms added in ssa refactor to `cspell` (#1385)
  chore(ssa refactor): Optimize constant `jmpif`s into `jmp`s (#1374)
  feat: Allow warnings by default (#1383)
  chore(github): Update GitHub Pull Request Template (#1370)
  chore(github): Update GitHub Bug Report Template (#1368)
  chore(ssa refactor): Update mem2reg pass to work with multiple functions and blocks (#1375)
  chore(ssa refactor): Add pass to simplify the control flow graph (#1373)
  chore(github): Update GitHub Feature Request Template (#1369)
@TomAFrench
Copy link
Member

Note for when documenting this PR. We need to update any examples of CI to explicitly disallow warnings. (see #1427)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat warnings as warnings by default (rather than errors)
3 participants