Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #1382
Description
Summary of changes
Allows warnings by default. The old default behavior of treating warnings like errors is now opt-in with the
--deny-warnings
flag. The old--allow-warnings
flag has been removed as it is no longer useful.Dependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Documentation needs
We should remove references to
--allow-warnings
in the documentation and add references to--deny-warnings
. Additionally, we should mention that unused variables are warnings rather than errors if we mention them at all. Deprecated constructs likeconstrain
do not need to be mentioned.Additional context