-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Links to Aztec docs from errors #3423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
reviewed
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links currently do not work. Is it because the docs were not yet re-deployed?
TomAFrench
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These links are working now
* master: (65 commits) chore: nargo fmt (#3612) fix: Flatten public inputs according to their index in numerial rather than ascii order (#3605) chore(docs): correct typo in `poseidon_hash` example in standard_library (#3608) feat: aztec-packages (#3599) chore: update code formatting to prevent parameter line wrapping (#3588) chore: Update ACIR artifacts (#3597) chore: Pull out aztec macros to their own crate and create an API for them in the compiler frontend (#3578) chore(ci): deduplicate javascript testing workflows (#3563) chore: Release Noir(0.19.4) (#3548) chore: update barretenberg to 0.16.0 (#3598) chore: move suite of test programs up to repository root (#3485) feat: send and receive unflattened public inputs to backend (#3543) feat: remove type arrays for flat slices (#3466) chore: clippy fix (#3561) chore: fix wrapping issue for constraints (#3590) feat: add support for tuple values in `noir_codegen` (#3592) chore: Remove concept of storage slot from the compiler (#3582) chore: Update ACIR artifacts (#3591) feat: export `CompiledCircuit` from codegened TS (#3589) fix: use 128 bits for constant bit shift (#3586) ...
TomAFrench
added a commit
that referenced
this pull request
Nov 28, 2023
* master: (47 commits) chore(docs): Links to Aztec docs from errors (#3423) chore: nargo fmt (#3612) fix: Flatten public inputs according to their index in numerial rather than ascii order (#3605) chore(docs): correct typo in `poseidon_hash` example in standard_library (#3608) feat: aztec-packages (#3599) chore: update code formatting to prevent parameter line wrapping (#3588) chore: Update ACIR artifacts (#3597) chore: Pull out aztec macros to their own crate and create an API for them in the compiler frontend (#3578) chore(ci): deduplicate javascript testing workflows (#3563) chore: Release Noir(0.19.4) (#3548) chore: update barretenberg to 0.16.0 (#3598) chore: move suite of test programs up to repository root (#3485) feat: send and receive unflattened public inputs to backend (#3543) feat: remove type arrays for flat slices (#3466) chore: clippy fix (#3561) chore: fix wrapping issue for constraints (#3590) feat: add support for tuple values in `noir_codegen` (#3592) chore: Remove concept of storage slot from the compiler (#3582) chore: Update ACIR artifacts (#3591) feat: export `CompiledCircuit` from codegened TS (#3589) ...
TomAFrench
added a commit
that referenced
this pull request
Nov 30, 2023
* master: (216 commits) chore(docs): address visibility issues in docs (#3643) chore: type formatting (#3618) fix: Restrict fill_internal_slices pass to acir functions (#3634) chore(docs): docs for v0.19.4 (#3601) feat: aztec-packages (#3626) chore: Move tests to the correct root (#3633) feat: Implement integer printing (#3577) fix: corrected the formatting of error message parameters in index out of bounds error (#3630) chore: Update ACIR artifacts (#3619) chore(debugger): Run debugger REPL in thread (#3611) chore: remove deprecated method (#3625) feat: Implement raw string literals (#3556) fix: docker builds (#3620) feat: Copy on write optimization for brillig (#3522) chore: separate methods in `dc_crate` into their own modules (#3585) feat: add special case for boolean AND in acir-gen (#3615) chore: Update ACIR artifacts (#3614) chore: remove `get_number_sequence` foreign calls (#3613) feat: Add package version to Nargo.toml metadata (#3427) chore(docs): Links to Aztec docs from errors (#3423) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This links to Aztec docs from Aztec-specific errors
Problem*
Resolves AztecProtocol/aztec-packages#2905 (in aztec-packages repo)
Summary*
Additional Context
Needs AztecProtocol/aztec-packages#3113 to be merged first
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.