chore: Pull out aztec macros to their own crate and create an API for them in the compiler frontend #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocessing functions
kevaundray
changed the title
|
Since we have pulled out the aztec macros code into a separate crate which always compiles, we can remove the yml workflow |
…e that bad, since each Macro processor is a pointer to a vtable
…) -- this should be fairly cheap
kevaundray
commented
Nov 26, 2023
jfecher
reviewed
Nov 27, 2023
5 tasks
vezenovm
approved these changes
Nov 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
TomAFrench
added a commit
that referenced
this pull request
Nov 28, 2023
* master: (65 commits) chore: nargo fmt (#3612) fix: Flatten public inputs according to their index in numerial rather than ascii order (#3605) chore(docs): correct typo in `poseidon_hash` example in standard_library (#3608) feat: aztec-packages (#3599) chore: update code formatting to prevent parameter line wrapping (#3588) chore: Update ACIR artifacts (#3597) chore: Pull out aztec macros to their own crate and create an API for them in the compiler frontend (#3578) chore(ci): deduplicate javascript testing workflows (#3563) chore: Release Noir(0.19.4) (#3548) chore: update barretenberg to 0.16.0 (#3598) chore: move suite of test programs up to repository root (#3485) feat: send and receive unflattened public inputs to backend (#3543) feat: remove type arrays for flat slices (#3466) chore: clippy fix (#3561) chore: fix wrapping issue for constraints (#3590) feat: add support for tuple values in `noir_codegen` (#3592) chore: Remove concept of storage slot from the compiler (#3582) chore: Update ACIR artifacts (#3591) feat: export `CompiledCircuit` from codegened TS (#3589) fix: use 128 bits for constant bit shift (#3586) ...
TomAFrench
added a commit
that referenced
this pull request
Nov 28, 2023
* master: (47 commits) chore(docs): Links to Aztec docs from errors (#3423) chore: nargo fmt (#3612) fix: Flatten public inputs according to their index in numerial rather than ascii order (#3605) chore(docs): correct typo in `poseidon_hash` example in standard_library (#3608) feat: aztec-packages (#3599) chore: update code formatting to prevent parameter line wrapping (#3588) chore: Update ACIR artifacts (#3597) chore: Pull out aztec macros to their own crate and create an API for them in the compiler frontend (#3578) chore(ci): deduplicate javascript testing workflows (#3563) chore: Release Noir(0.19.4) (#3548) chore: update barretenberg to 0.16.0 (#3598) chore: move suite of test programs up to repository root (#3485) feat: send and receive unflattened public inputs to backend (#3543) feat: remove type arrays for flat slices (#3466) chore: clippy fix (#3561) chore: fix wrapping issue for constraints (#3590) feat: add support for tuple values in `noir_codegen` (#3592) chore: Remove concept of storage slot from the compiler (#3582) chore: Update ACIR artifacts (#3591) feat: export `CompiledCircuit` from codegened TS (#3589) ...
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
# Description This is a followup to #3578 where we move the feature flag from compile time to runtime producing a single binary. EDIT: This was initially was meant to change it to runtime flag, but there was quite a lot of effort to make this work. We can introduce an environment variable in the future to turn off all macros if this turn out to be a problem ## Problem\* Resolves <!-- Link to GitHub Issue --> ## Summary\* ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Tom French <tom@tomfren.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates an API for macros to modify the AST before and after type checking. The aztec macro is pulled out into its own crate and is now feature flagged on the noirc_driver.
Problem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.