Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove concept of storage slot from the compiler #3582

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

kevaundray
Copy link
Contributor

Description

Resolves #3580

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor Author

Pinging Alvaro to confirm that this is not being used anywhere in aztec-packages

@TomAFrench TomAFrench self-requested a review November 27, 2023 10:39
@TomAFrench
Copy link
Member

I think we could make this a cheeky non-breaking if aztec never used this feature.

@TomAFrench
Copy link
Member

Reminder that we should push out 0.19.4 before merging this if we're keeping it as breaking.

@kevaundray
Copy link
Contributor Author

Changing to non-breaking!

@kevaundray kevaundray changed the title chore!: Remove concept of storage slot from the compiler chore: Remove concept of storage slot from the compiler Nov 27, 2023
@TomAFrench TomAFrench added this pull request to the merge queue Nov 27, 2023
Merged via the queue into master with commit 9f1382f Nov 27, 2023
35 checks passed
@TomAFrench TomAFrench deleted the kw/remove-storage-slot branch November 27, 2023 17:46
TomAFrench added a commit that referenced this pull request Nov 27, 2023
* master: (56 commits)
  chore: Remove concept of storage slot from the compiler (#3582)
  chore: Update ACIR artifacts (#3591)
  feat: export `CompiledCircuit` from codegened TS (#3589)
  fix: use 128 bits for constant bit shift (#3586)
  fix: Somewhat reduce mem2reg memory usage (#3572)
  fix: Remove quotes from println output (#3574)
  chore: Rename error2 variable (#3584)
  chore: nargo fmt (#3587)
  feat: codegen typed interfaces for functions in `noir_codegen` (#3533)
  chore: add dependency on noir_js from docs package (#3559)
  chore: Docs 0.19.3 (#3545)
  chore(debugger): Inject abstract foreign call executor to debugger (#3550)
  chore: nargo fmt (#3549)
  fix: Compiler version error message (#3558)
  chore(docs): Update link to docs' GitHub (#3555)
  chore(fmt): refactor the way we handle shapes in the formatter (#3546)
  feat: add --check option to nargo fmt for dry-run formatting verification (#3530)
  chore: Update ACIR artifacts (#3528)
  chore: Release Noir(0.19.3) (#3514)
  chore: Updates bb dependency to 0.15.1 (#3536)
  ...
TomAFrench added a commit that referenced this pull request Nov 27, 2023
* master:
  chore: clippy fix (#3561)
  chore: fix wrapping issue for constraints (#3590)
  feat: add support for tuple values in `noir_codegen` (#3592)
  chore: Remove concept of storage slot from the compiler (#3582)
  chore: Update ACIR artifacts (#3591)
  feat: export `CompiledCircuit` from codegened TS (#3589)
  fix: use 128 bits for constant bit shift (#3586)
  fix: Somewhat reduce mem2reg memory usage (#3572)
  fix: Remove quotes from println output (#3574)
TomAFrench added a commit that referenced this pull request Nov 28, 2023
* master: (65 commits)
  chore: nargo fmt (#3612)
  fix: Flatten public inputs according to their index in numerial rather than ascii order (#3605)
  chore(docs): correct typo in `poseidon_hash` example in standard_library (#3608)
  feat: aztec-packages (#3599)
  chore: update code formatting to prevent parameter line wrapping (#3588)
  chore: Update ACIR artifacts (#3597)
  chore: Pull out aztec macros to their own crate and create an API for them in the compiler frontend (#3578)
  chore(ci): deduplicate javascript testing workflows (#3563)
  chore: Release Noir(0.19.4) (#3548)
  chore: update barretenberg to 0.16.0 (#3598)
  chore: move suite of test programs up to repository root (#3485)
  feat: send and receive unflattened public inputs to backend (#3543)
  feat: remove type arrays for flat slices (#3466)
  chore: clippy fix (#3561)
  chore: fix wrapping issue for constraints (#3590)
  feat: add support for tuple values in `noir_codegen` (#3592)
  chore: Remove concept of storage slot from the compiler (#3582)
  chore: Update ACIR artifacts (#3591)
  feat: export `CompiledCircuit` from codegened TS (#3589)
  fix: use 128 bits for constant bit shift (#3586)
  ...
TomAFrench added a commit that referenced this pull request Nov 28, 2023
* master: (47 commits)
  chore(docs): Links to Aztec docs from errors (#3423)
  chore: nargo fmt (#3612)
  fix: Flatten public inputs according to their index in numerial rather than ascii order (#3605)
  chore(docs): correct typo in `poseidon_hash` example in standard_library (#3608)
  feat: aztec-packages (#3599)
  chore: update code formatting to prevent parameter line wrapping (#3588)
  chore: Update ACIR artifacts (#3597)
  chore: Pull out aztec macros to their own crate and create an API for them in the compiler frontend (#3578)
  chore(ci): deduplicate javascript testing workflows (#3563)
  chore: Release Noir(0.19.4) (#3548)
  chore: update barretenberg to 0.16.0 (#3598)
  chore: move suite of test programs up to repository root (#3485)
  feat: send and receive unflattened public inputs to backend (#3543)
  feat: remove type arrays for flat slices (#3466)
  chore: clippy fix (#3561)
  chore: fix wrapping issue for constraints (#3590)
  feat: add support for tuple values in `noir_codegen` (#3592)
  chore: Remove concept of storage slot from the compiler (#3582)
  chore: Update ACIR artifacts (#3591)
  feat: export `CompiledCircuit` from codegened TS (#3589)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove concept of storage slot from the codebase
2 participants