Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty SEARCH result is treated as an error leading to unhealthy client #518

Closed
roman-khimov opened this issue Sep 12, 2023 · 0 comments · Fixed by #521
Closed

Empty SEARCH result is treated as an error leading to unhealthy client #518

roman-khimov opened this issue Sep 12, 2023 · 0 comments · Fixed by #521
Assignees
@smallhive @roman-khimov
Labels
bug Something isn't working pool Issue related to the pool
Milestone
v1.0.0-rc12

Comments

@roman-khimov
Copy link
Member

Current Behavior

HTTP gateway SEARCHing for things often doesn't find anything (it's OK, there are a lot of random requests to the gateway). This leads to io.EOF returned, but it's counted as an error in Pool (incError) and eventually leads to declaring client unhealthy.

Expected Behavior

It's just not an error, it's normal behavior.

Possible Solution

Review error handling in updateErrorRate.

Context

Mainnet gateways (HTTP 0.27.4) went down because of this.
@roman-khimov roman-khimov added bug Something isn't working pool Issue related to the pool labels Sep 12, 2023
@roman-khimov roman-khimov added this to the v1.0.0 milestone Sep 12, 2023
@smallhive smallhive mentioned this issue Sep 12, 2023
Closed
@roman-khimov roman-khimov mentioned this issue Sep 12, 2023
Closed
@roman-khimov roman-khimov self-assigned this Sep 12, 2023
roman-khimov added a commit that referenced this issue Sep 12, 2023
@roman-khimov
client: do not send objectSearchStream statistics from Read
7e6cce1 
Only do it from Close, one SEARCH request -> one statistic update.

Fixes #518 at the same time, since in Close() io.EOF is filtered out (as it
should be).

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov roman-khimov mentioned this issue Sep 12, 2023
Merged
roman-khimov added a commit that referenced this issue Sep 12, 2023
@roman-khimov
Fix stream statistics and pool restarts (#521)
c0eefd5 
Replaces #519, fixes #518 and #520.
@roman-khimov roman-khimov modified the milestones: v1.0.0, v1.0.0-rc12 Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smallhive smallhive

@roman-khimov roman-khimov

Labels
bug Something isn't working pool Issue related to the pool
Projects
None yet
Milestone
v1.0.0-rc12
2 participants
@smallhive @roman-khimov