Fix stream statistics and pool restarts #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tie statistics to Close() invocation, have it collected once per operation. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Multiple (unknown in advance) stream operations make little sense. Signed-off-by: Roman Khimov <roman@nspcc.ru>
There can be a lot of Write() calls, but there is only one Close() (usually). Signed-off-by: Roman Khimov <roman@nspcc.ru>
d6d6a41 regression, refactor err/x.err duality along the way. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Only do it from Close, one SEARCH request -> one statistic update. Fixes #518 at the same time, since in Close() io.EOF is filtered out (as it should be). Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
requested review from
cthulhu-rider,
smallhive and
carpawell
as code owners
roman-khimov
changed the title
carpawell
approved these changes
Sep 12, 2023
getRawClient never returned a proper client for unhealthy nodes, so restart always failed. f38e127 regression. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
fix-stream-statistics
branch
from
56e9398
to
1b3819e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #519, fixes #518 and #520.