Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process io.EOF but not count #519

Closed
wants to merge 1 commit into from
Closed

Process io.EOF but not count #519

wants to merge 1 commit into from

Conversation

smallhive
Copy link
Contributor

closes #518

@smallhive smallhive force-pushed the 518-empty-search-result-is-treated-as-an-error-leading-to-unhealthy-client branch from 219e6d7 to 0cbe480 Compare September 12, 2023 10:04
@smallhive
pool: Process io.EOF but not count
38f25d9 
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive force-pushed the 518-empty-search-result-is-treated-as-an-error-leading-to-unhealthy-client branch from 0cbe480 to 38f25d9 Compare September 12, 2023 10:05
@smallhive smallhive marked this pull request as ready for review September 12, 2023 10:39
@roman-khimov roman-khimov mentioned this pull request Sep 12, 2023
Merged
roman-khimov added a commit that referenced this pull request Sep 12, 2023
@roman-khimov
Fix stream statistics and pool restarts (#521)
c0eefd5 
Replaces #519, fixes #518 and #520.
roman-khimov
roman-khimov requested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsolete

@smallhive smallhive closed this Sep 13, 2023
@roman-khimov roman-khimov deleted the 518-empty-search-result-is-treated-as-an-error-leading-to-unhealthy-client branch September 13, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov requested changes

@carpawell carpawell carpawell approved these changes

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty SEARCH result is treated as an error leading to unhealthy client
3 participants
@smallhive @roman-khimov @carpawell