MSM FFA: Create msm/ffa folder & structure #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2024
volhovm
force-pushed
the
volhovm/1793-msm-foreign-field-addition-part1
branch
from
69121e9 to
7c4d7f3
Compare
Base automatically changed from
volhovm/1790-connect-expr-framework-with-prover
to
master
March 5, 2024 15:26
volhovm
force-pushed
the
volhovm/1793-msm-foreign-field-addition-part1
branch
from
7c4d7f3 to
68ed4c8
Compare
dannywillems
reviewed
Mar 5, 2024
| @@ -41,7 +42,7 @@ pub fn main() { | |||
|
|
|||
| let circuit_env = generate_random_msm_witness(); | |||
| let proof_inputs = circuit_env.get_witness(); | |||
| let constraint_exprs = circuit_env.get_exprs_add(); | |||
There was a problem hiding this comment.
For a follow-up: we can move the main file in the subdirectory I think
dannywillems
reviewed
Mar 5, 2024
| /// ``` | ||
| /// A list of such constraints is used to represent the entire circuit and will | ||
| /// be used to build the quotient polynomial. | ||
| pub type MSMExpr<F> = Expr<ConstantExpr<F>, Column>; |
There was a problem hiding this comment.
For a follow-up: I think expr.rs can be deleted. We only need the generalized definition of Column.
dannywillems
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a directory structure for having
/ffacode.Parent branch PR: #1839
Part of #1791 .