-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSM: Bring in quotient polynomial and constraints #1839
MSM: Bring in quotient polynomial and constraints #1839
Conversation
e705daa
to
479421b
Compare
a52ebbd
to
d172ca6
Compare
72dd90e
to
328aaf3
Compare
328aaf3
to
59538b1
Compare
59538b1
to
bcd09ef
Compare
|
Oopsie. Sorry, wrong PR. |
@volhovm Can you fix the conflicts please? |
@dannywillems ah, oh well. on it. |
@dannywillems I know it's annoying but I can't really squash these without messing everything up sadly because I merged |
61c7d70
to
dad2ea3
Compare
The only way I think is restarting the branch before the git merge, squash, redo git merge, git push force. |
@dannywillems all addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just merge it. We'll fix later. We will iterate over it. I didn't test it, but we will after. It does create tons of conflicts in the next PRs.
Let's have very small PR later.
I would revert the changes in kimchi to decrease as much as possible the changes outside of the MSM code
Solves #1790: