Merge stabilization/2210 into main #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Murray <scottmur@amazon.com>
…set (#412) Signed-off-by: Qing Tao <55564570+VickyAtAZ@users.noreply.github.com>
Signed-off-by: Scott Murray <scottmur@amazon.com>
removing WARP suite from AtomSampleViewer
…lTest to avoid crashes. Testing: I was able to run AssetLoadTest, increase size to 25x25x25, exit the sample, load DynamicMaterialTest, increase size to 25x25x25, and exit, in the same session without crashing. Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
…c/RestoreOldLatticeLimits Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
Signed-off-by: Santi Paprika <santi.gonzalez@huawei.com>
…s in parallax surfaces. I added a new setting to the Parallax sample that allows turning off all lights, so the surface is rendered black. This allows us to use a much tighter threshold on the screenshot comparison, since an entirely black unlit surface will not exhibit the sensitive platform differences we are used to seeing on parallax materials. This should ensure any depth-test calculation noise, which show up as gray firefly pixels, will cause the test threshold to fail. I included many screenshots because the noise seems to be platform - and/or driver-dependent, so having more screenshots increases the chances of detecting failures. Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
…ace (#411) * Mark Linux as supporting viewport resize for the ASV scripting interface Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com> * Mark AtomSampleViewerStandalone as supported on linux Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>
Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
…ases where the IBL from one sample could persist when opening another sample, for example when going directly from the Mesh sample to the Parallax sample. Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
Signed-off-by: puvvadar <puvvadar@amazon.com>
Signed-off-by: puvvadar <puvvadar@amazon.com>
Remove GridMate from AtomSampleViewer
…c/FixingParallaxIssues Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
…OldLatticeLimits Restored old lattice size limits for AssetLoadTest and DynamicMaterialTest
Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
Signed-off-by: dmcdiarmid-ly <63674186+dmcdiarmid-ly@users.noreply.github.com>
…teDetailMapScreenshotThresholdIncrease Cherry-Pick Increased screenshot tolerance for some benign failing tests
Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
…arallaxIssues Added New "ParallaxDepthArtifacts" Screenshot Tests
Updated ReflectionProbeFeatureProcessor method names
Add Eye material sample and regression test
…d meshes (#356) * Cherry-picking dc1133a Signed-off-by: Tommy Walton <waltont@amazon.com> * Fix missing namespace and remove pragma optimize Signed-off-by: amzn-tommy <waltont@amazon.com> * Fix size_t cast issues Signed-off-by: amzn-tommy <waltont@amazon.com> * Add working support for multiple sub-meshes to ProceduralSkinnedMeshUtils Signed-off-by: Tommy Walton <waltont@amazon.com> * Fix merge error while cherry-picking Signed-off-by: Tommy Walton <waltont@amazon.com>
…Processor (#431) Signed-off-by: Tommy Walton <waltont@amazon.com>
This corresponds to o3de/o3de#9292 "Removed PDO Shadow Bias That Is Obsolete". Also, some aspects of the screenshots have been updated that weren't necessarily impacted by the depth bias changes, but more for routine maintenance to make sure the baselines match recent behavior that looks correct. Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
… cases the shadows have been reduced. I'm not sure what caused these screenshots to change (it's not related to my recent work around PDO depth bias), but the changes seem reasonable. Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
…ng for this material Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
…hotMaintenance Signed-off-by: santorac <55155825+santorac@users.noreply.github.com>
… made minor changes to the sample settings Signed-off-by: dmcdiarmid-ly <63674186+dmcdiarmid-ly@users.noreply.github.com>
Signed-off-by: dmcdiarmid-ly <63674186+dmcdiarmid-ly@users.noreply.github.com>
…or ShaderReloadTestComponent Signed-off-by: antonmic <56370189+antonmic@users.noreply.github.com>
DiffuseProbeGrid Gem
Signed-off-by: jiaweig <51759646+jiaweig-amzn@users.noreply.github.com>
Move submitIndex to a CommandList::Submit parameter
Fixes the multi-scene example component using the wrong name for requesting the reflection probe feature processor. Also fixes ResetScene() so it actually gets the new scene instead of holding onto a possibly stale pointer. Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>
The rtti for aux geom was updated to include the namespace (which is standard) so this place needs to be updated to reference that namespace as well. Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>
* Add SettingsRegistry BehaviorContext reflection plus add some test scripts Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com> * Remove some debug #pragma's Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com> * Delete test script Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com> Signed-off-by: rgba16f <82187279+rgba16f@users.noreply.github.com>
Signed-off-by: Bindless-Chicken <1039134+Bindless-Chicken@users.noreply.github.com>
…erReloadTest ShaderReloadTestComponent Fix
…493) It was using curly braces, now it is using parenthesis. It was causing a compilation on a developers machine. ``` D:/github/AtomSampleViewer/Gem/Code/Source/Utils/ImGuiShaderUtils.cpp(32,46): error C2398: Element '1': conversion from 'unsigned __int64' to '_Elem' requires a narrowing conversion 3> with 3> [ 3> _Elem=char 3> ] 3> AZStd::string divider{header.size(), '-'}; 3> ^ 3>D:/github/AtomSampleViewer/Gem/Code/Source/Utils/ImGuiShaderUtils.cpp(32,53): warning C4267: 'initializing': conversion from 'size_t' to '_Elem', possible loss of data 3> with 3> [ 3> _Elem=char 3> ] 3> AZStd::string divider{header.size(), '-'}; ``` Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com>
Fix target blend state name
Signed-off-by: Qing Tao <55564570+VickyAtAZ@users.noreply.github.com> Signed-off-by: Qing Tao <55564570+VickyAtAZ@users.noreply.github.com> Co-authored-by: Tobias Alexander Franke <thefranke@users.noreply.github.com>
Signed-off-by: Ken Pruiksma <pruiksma@amazon.com>
Happens with clang and gcc (on at least linux). Signed-off-by: Joerg H. Mueller <joerg.mueller@huawei.com> Signed-off-by: Joerg H. Mueller <joerg.mueller@huawei.com>
…ently timed out Signed-off-by: Scott Murray <scottmur@amazon.com>
adjusting the timeout duration of the ASV main suite job
Signed-off-by: Scott Murray <scottmur@amazon.com>
time-out 1500 appears to be the limit
…ontain Vulkan versions, not DX12 versions (#496) * Add suffix to screenshot file name Signed-off-by: jiaweig <51759646+jiaweig-amzn@users.noreply.github.com> * Update screenshot scripts Signed-off-by: jiaweig <51759646+jiaweig-amzn@users.noreply.github.com> * Remove duplicated function Signed-off-by: jiaweig <51759646+jiaweig-amzn@users.noreply.github.com> * Change to add the env info to a folder instead of the file name Signed-off-by: jiaweig <51759646+jiaweig-amzn@users.noreply.github.com> * Optimize code Signed-off-by: jiaweig <51759646+jiaweig-amzn@users.noreply.github.com> Signed-off-by: jiaweig <51759646+jiaweig-amzn@users.noreply.github.com>
cgalvan
approved these changes
Oct 11, 2022
AMZN-daimini
approved these changes
Oct 11, 2022
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merge latest stabilization/2210 into main
Related issue o3de/o3de#11098
How was this PR tested?
See related stabilization/2210 PRs for testing