[Microsoft] fix reading OpenID Connect token responses

[ccutrer]

when using Microsoft's OpenID Connect service (as documented at
https://azure.microsoft.com/en-us/documentation/articles/active-directory-v2-protocols/)
if you only request the openid scope, Microsoft only returns an id_token,
with no access_token. so treat that as a valid response.

[jeffcarbs]

This line is a little tough to read. I'd change to something like this:

response_contains_token = response.parsed.is_a?(Hash) &&
  (response.parsed['access_token'] || response.parsed['id_token'])

error = Error.new(response)
raise(error) if options[:raise_errors] && !(response_contains_token)

Also this method now breaks the lint check, which is failing the build. In a method above there's a comment to disable a few extra Rubocops, I'd add the same comment to this method def as well:

# rubocop:disable CyclomaticComplexity, MethodLength, Metrics/AbcSize

[jeffcarbs]

I've run into the same issue. I left some comments to help fix the build and then hopefully this could get some attention from 👍

[ccutrer]

I've updated the PR with your suggestions.

[xtagon]

@ccutrer Are you still interested in getting this merged? Looks like there are just some conflicts now.

[natebird]

Any movement on resolving the conflicts so this can be merged @ccutrer?

[ccutrer]

I'd almost forgotten this PR existed. I've just been updating our monkey patch in our app with each bump of this gem. I'll update the PR

[ccutrer]

PR updated with conflicts resolved, and specs passing.

[coveralls]

Pull Request Test Coverage Report for Build 827

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at ?%

---

Totals
Change from base Build 826:	0.0%
Covered Lines:
Relevant Lines:	0

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 827

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at ?%

---

Totals
Change from base Build 826:	0.0%
Covered Lines:
Relevant Lines:	0

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 827

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at ?%

---

Totals
Change from base Build 826:	0.0%
Covered Lines:
Relevant Lines:	0

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 830

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at ?%

---

Totals
Change from base Build 826:	0.0%
Covered Lines:
Relevant Lines:	0

---

💛 - Coveralls

[pboling]

Looks great, thanks for updating!

[jonspalmer]

I know this is an old PR but is there any advice on how to use Microsoft responses that only hav id_token in the. This fix make that a valid response but the AccessToken class still expects the access_token in the response hash.

What's the fix? Is it to subclass AccessToken ?

[anvox]

Thansk @jonspalmer I afraid extending AccessToken is the only option for now. I see you found #511 already, we could move conversation on it for a completely solution for this.

[jonspalmer]

Happy to move it there. I have lots of questions :D perhaps a few suggestions too.