Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.4.5 to release #518 #534

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

mattboldt
Copy link

@coveralls
Copy link

coveralls commented Mar 10, 2021

Pull Request Test Coverage Report for Build 1069

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 97.708%

Totals Coverage Status
Change from base Build 1044: -0.02%
Covered Lines: 341
Relevant Lines: 349

💛 - Coveralls

@pboling
Copy link
Member

pboling commented Mar 18, 2021

Thanks @mattboldt !

@pboling pboling merged commit 94b1329 into oauth-xx:1-4-stable Mar 18, 2021
@pboling
Copy link
Member

pboling commented Mar 18, 2021

@mattboldt the answer to your question is:

Yes, #518 must be ported to master, and hasn't been thus far. There was an attempt at a older, but similar solution merged to master (#516), but it was later reverted.

ref: #516 (comment)

This is one of the reasons why we still do not have a v2 of the gem ready.

@pboling
Copy link
Member

pboling commented Mar 18, 2021

@mattboldt 1.4.5 is released

@mattboldt mattboldt deleted the 1-4-stable branch March 20, 2021 20:10
@mattboldt
Copy link
Author

mattboldt commented Mar 20, 2021

@pboling Thank you so much! Do y'all plan to merge 1-4-stable -> master for v2, or will you be cherry picking certain changes? I could look into getting #518 ported to master. I think the default proc should support what v1.4.5 does now.

Edit: fwiw, before I discovered this fix, I started on a PR to improve exception handling around missing tokens. It's kinda moot now, but I think the idea has merit https://github.com/oauth-xx/oauth2/compare/master...mattboldt:add_error_message_for_missing_tokens?expand=1

@pboling
Copy link
Member

pboling commented Mar 20, 2021

@mattboldt There will be no merges from 1-4-stable to master. Generally fixes will not be back-ported unless someone wants to do the work. Maintenance effort will go into preparing 2.0 for release.

I do occasionally cherry pick things, but the branches have diverged in many ways.

I will take a look at the branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants