Add Client option for access_token_class #516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
There is no way to use
OAuth2::Client
strategies such asauth_code
AND supply a custom access_token_class.OAuth2::Client.get_token
has an optional argument for the access_token_class to instantiate.However, callers of it have to know to use it and none of the strategies do so. This means the anyone needing a custom access_token_class, #243 or #511, need to jump through hoops to get the behavior they want. For example subclassing
OAuth2::Client
just to change the default classWhat I did
Added a new option,
access_token_class
, toOAuth2::Client
which is used as the defaultaccess_token_class
for all calls toget_token
.This is a safe, non-breaking change.