Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using templated META file, the generated dune-package is wrong #3746

Closed
Kakadu opened this issue Aug 26, 2020 · 2 comments
Closed

Using templated META file, the generated dune-package is wrong #3746

Kakadu opened this issue Aug 26, 2020 · 2 comments
Labels
bug

Comments

@Kakadu
Copy link
Contributor

Kakadu commented Aug 26, 2020 •
edited
Loading

Expected Behavior

dune-package is OK

Actual Behavior

It is in wrong format

dune build src
File "/home/kakadu/.opam/4.10.0+fp+flambda/lib/GT/dune-package", line 3, characters 1-8:
3 | (version 8f75697-dirty)
     ^^^^^^^
Error: Unknown field version

Reproduction

  1. Install a package with META.PACKAGENAME.tempalte present
  2. Compile something that depends on your package

Workaround:

install:
	dune build @install
	dune install
	echo "(lang dune 2.7)" > `ocamlfind query PACKAGENAME`/dune-package
	echo "(use_meta)" >> `ocamlfind query PACKAGENAME`/dune-package
	dune describe --only-packages=PACKAGENAME >> `ocamlfind query PACKAGENAME`/dune-package

I discussed that yesterday with @rgrinberg

P.S. OK, maybe workaround is not actually a valid workaround.
@rgrinberg rgrinberg added the bug label Aug 26, 2020
@rgrinberg
Copy link
Member

Fixed by #3743

@Kakadu
Copy link
Contributor Author

Kakadu commented Aug 26, 2020

It seems that my issue is really fixed now. Thanks!

@Kakadu Kakadu closed this as completed Aug 26, 2020
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Sep 3, 2020
@rgrinberg
[new release] dune-build-info, dune, dune-configurator, dune-action-p…
f714744 
…lugin, dune-private-libs and dune-glob (2.7.1)

CHANGES:

- configurator: More flexible probing of `#define`. We allow duplicate values in
  the object file, as long as they are the same after parsing. (ocaml/dune#3739, fixes
  ocaml/dune#3736, @rgrinberg)

- Record instrumentation backends in dune-package files. This makes it possible
  to use instrumentation backends defined in installed libraries (eg via OPAM).
  (ocaml/dune#3735, @nojb)

- Add missing `.aux` & `.glob` targets to coq rules (ocaml/dune#3721, fixes ocaml/dune#3437,
  @rgrinberg)

- Fix `dune-package` installation when META templates are present (ocaml/dune#3743, fixes
  ocaml/dune#3746, @rgrinberg)

- Resolve symlinks before running `$ git diff` (ocaml/dune#3750, fixes ocaml/dune#3740, @rgrinberg)

- Cram tests: when checking that all test directories contain a `run.t` file,
  skip empty directories. These can be left around by git. (ocaml/dune#3753, @emillon)
@rgrinberg rgrinberg mentioned this issue Sep 3, 2020
Merged
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Sep 5, 2020
@rgrinberg
[new release] dune-build-info, dune, dune-configurator, dune-action-p…
8250214 
…lugin, dune-private-libs and dune-glob (2.7.1)

CHANGES:

- configurator: More flexible probing of `#define`. We allow duplicate values in
  the object file, as long as they are the same after parsing. (ocaml/dune#3739, fixes
  ocaml/dune#3736, @rgrinberg)

- Record instrumentation backends in dune-package files. This makes it possible
  to use instrumentation backends defined in installed libraries (eg via OPAM).
  (ocaml/dune#3735, @nojb)

- Add missing `.aux` & `.glob` targets to coq rules (ocaml/dune#3721, fixes ocaml/dune#3437,
  @rgrinberg)

- Fix `dune-package` installation when META templates are present (ocaml/dune#3743, fixes
  ocaml/dune#3746, @rgrinberg)

- Resolve symlinks before running `$ git diff` (ocaml/dune#3750, fixes ocaml/dune#3740, @rgrinberg)

- Cram tests: when checking that all test directories contain a `run.t` file,
  skip empty directories. These can be left around by git. (ocaml/dune#3753, @emillon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgrinberg @Kakadu